Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrie plugin can generate massive argument lists #407

Closed
alanz opened this issue Sep 16, 2020 · 0 comments · Fixed by #408
Closed

retrie plugin can generate massive argument lists #407

alanz opened this issue Sep 16, 2020 · 0 comments · Fixed by #408
Assignees
Labels
component: hls-retrie-plugin performance Issues about memory consumption, responsiveness, etc. type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@alanz
Copy link
Collaborator

alanz commented Sep 16, 2020

While trying to play with the new case split plugin, I introduced the function

foo :: StmtLR GhcPs GhcPs (LHsExpr GhcPs) -> ()
foo = _

(the second line went through various iterations) at line 2093.

It initially produced case split image.

After editing it a bit (and breaking it), the emacs session became unresponsive. And it seemed the retrie plugin was sending code actions with very long argument lists. https://gist.github.com/alanz/c7b110fa6783a09085d4e8537ed0e2e1#file-really-long-codeaction-response-L38

Your environment

  • Output of haskell-language-server --probe-tools or haskell-language-server-wrapper --probe-tools
haskell-language-server-wrapper --probe-tools
haskell-language-server version: 0.4.0.0 (GHC: 8.10.2) (PATH: /home/alanz/.cabal/store/ghc-8.10.2/haskell-language-server-0.4.0.0-2ecd111aa38859cd0677f5794cf92ff297c44a4728d797c3bb010cbe21bedd56/bin/haskell-language-server-wrapper)
Tool versions found on the $PATH
cabal:		3.2.0.0
stack:		2.3.3
ghc:		8.8.4
  • Which lsp-client do you use

    • emacs, (version 28.0.50)
  • Describe your project (alternative: link to the project)

https://github.com/ghc/ghc/blob/wip/az/exactprint

I was not able to reproduce the problem.

@pepeiborra pepeiborra self-assigned this Sep 16, 2020
@jneira jneira added component: hls-retrie-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. performance Issues about memory consumption, responsiveness, etc. labels Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: hls-retrie-plugin performance Issues about memory consumption, responsiveness, etc. type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants