Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook redesign #3600

Closed
ezyang opened this issue Jul 22, 2016 · 7 comments
Closed

Hook redesign #3600

ezyang opened this issue Jul 22, 2016 · 7 comments
Labels
Cabal: hooks old-milestone: ⊥ Moved from https://github.com/haskell/cabal/milestone/5 status: consider closing type: enhancement
Milestone

Comments

@ezyang
Copy link
Contributor

ezyang commented Jul 22, 2016

@ttuegel, let's make this a tracking ticket for hook redesign.

I'm collecting tickets of things that should be fixed in the redesign:

@dcoutts
Copy link
Contributor

dcoutts commented Jul 24, 2016

And remove things like the program db in some of the flag types which are there only to avoid modifying the hook function types. See the TODO in the code.

@fmaste
Copy link
Collaborator

fmaste commented Aug 11, 2016

Now with #3670 we can add a hook to generate the autogen-modules. The hook output could be Just Text and its input the PackageDescription and which component to build. It defaults to create the Paths_* module or else returns Nothing so others can be built with a different hook.

With this it would be possible to override the Paths_* module and generate modules on the fly without having to guess where to put them (dist/build, dist/build/exe, dist/libbuild, etc) or when to create them (on configure, on build, before cpp, etc).

@ezyang
Copy link
Contributor Author

ezyang commented Aug 22, 2016

@fmaste, do you want to make a ticket describing this suggestion in more detail (like a spec), and then edit the description here to link to it?

@ezyang ezyang modified the milestones: Cabal 2.0, Sep 6, 2016
@ezyang
Copy link
Contributor Author

ezyang commented Sep 8, 2016

Sorry, I don't think this is going to happen for 2.0.

@andreabedini
Copy link
Collaborator

@Mikolaj @sheaf Do you think this can be closed after the implementation of #9292?

@Mikolaj
Copy link
Member

Mikolaj commented Feb 7, 2025

I guess so? @mpickering, @sheaf, @ezyang, @ttuegel, are there any morsels of ancient wisdom still to be found here? What about the tickets listed in the description? Can some of them be closed and the remaining ones refreshed?

@Mikolaj
Copy link
Member

Mikolaj commented Feb 24, 2025

Thank you for you work, everybody. Closing.

@Mikolaj Mikolaj closed this as completed Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cabal: hooks old-milestone: ⊥ Moved from https://github.com/haskell/cabal/milestone/5 status: consider closing type: enhancement
Projects
None yet
Development

No branches or pull requests

6 participants