Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken "Edit on GitHub" link #567

Closed
Blaisorblade opened this issue Aug 13, 2016 · 5 comments · Fixed by #571
Closed

Broken "Edit on GitHub" link #567

Blaisorblade opened this issue Aug 13, 2016 · 5 comments · Fixed by #571
Assignees

Comments

@Blaisorblade
Copy link

The "Edit on GitHub" link on http://haskell-servant.readthedocs.io/en/stable/ is broken, because it assumes sources are written in Markdown rather than RST, and uses an .md extension.

It points to
https://github.com/haskell-servant/servant/blob/8eb412ff23edf83baa7978587e71791fd9498b5a/doc/index.md
rather than
https://github.com/haskell-servant/servant/blob/8eb412ff23edf83baa7978587e71791fd9498b5a/doc/index.rst.

@soenkehahn
Copy link
Contributor

Thanks for the report. Certainly true. I'm not entirely sure, how to fix it at first glance...

@soenkehahn
Copy link
Contributor

Maybe it's this bug: readthedocs/readthedocs.org#2130

@soenkehahn
Copy link
Contributor

Following the advice from readthedocs/readthedocs.org#2130 hopefully #571 fixes this.

@soenkehahn
Copy link
Contributor

Yes, #571 fixes this. Will only land on readthedocs once we cut a new release.

@Blaisorblade
Copy link
Author

Thanks a lot for your diligent investigation and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants