Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that names are DNS compatible before adding to SANs #3918

Closed
jefferai opened this issue Feb 6, 2018 · 0 comments
Closed

Verify that names are DNS compatible before adding to SANs #3918

jefferai opened this issue Feb 6, 2018 · 0 comments
Milestone
0.9.4

Comments

@jefferai
Copy link
Member

jefferai commented Feb 6, 2018

If someone uses a non-DNS name as a CN, we should ensure before copying it to DNS SANs that it is actually a valid DNS name.
@jefferai jefferai added this to the 0.9.4 milestone Feb 6, 2018
@jefferai jefferai mentioned this issue Feb 6, 2018
Open
@vishalnayak vishalnayak mentioned this issue Feb 9, 2018
Merged
jefferai added a commit that referenced this issue Feb 9, 2018
@jefferai
Add verification before adding to DNS names to also fix #3918
ae579f2
jefferai pushed a commit that referenced this issue Feb 9, 2018
@vishalnayak @jefferai
added a flag to make common name optional if desired (#3940)
58cab5f 
* added a flag to make common name optional if desired

* Cover one more case where cn can be empty

* remove skipping when empty; instead check for emptiness before calling validateNames

* Add verification before adding to DNS names to also fix #3918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.4
Development

No branches or pull requests
1 participant
@jefferai