Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL policy deletion from web UI fails if it contains dots #5915

Closed
diegosainz opened this issue Dec 7, 2018 · 4 comments
Closed

ACL policy deletion from web UI fails if it contains dots #5915

diegosainz opened this issue Dec 7, 2018 · 4 comments
Labels
Milestone

Comments

@diegosainz
Copy link

Describe the bug
Cannot delete policies with dots (".") in their names from the web interface (tested in latest Chrome and Firefox versions)

To Reproduce
Steps to reproduce the behavior:

  1. Create a policy called "some.policy" with any content
  2. Try to delete it (from the web UI)
  3. See error in console:
vendor-9e6bb7bde315fb2e3f4c03b643b80ad9.js:3086 Uncaught r {stack: "Error: Property set failed: object in path "should…ndor-9e6bb7bde315fb2e3f4c03b643b80ad9.js:3734:15)", description: undefined, fileName: undefined, lineNumber: undefined, message: "Property set failed: object in path "shouldDelete-some" could not be found.", …}

Expected behavior
A confirmation dialog should appear asking for the policy deletion

Environment:

  • Vault Server Version (retrieve with vault status): 1.0.0
  • Vault CLI Version (retrieve with vault version): 1.0.0
  • Server Operating System/Architecture: Ubuntu 18.04
@meirish meirish added the ui label Dec 7, 2018
@meirish
Copy link
Contributor

meirish commented Dec 11, 2018

As a work around, you should still be able to delete the policy from the edit page (or the web CLI) until we land a fix for this.

@diegosainz
Copy link
Author

Thank you, @meirish - yes, we were deleting those keys from the cli without any problems.

@meirish
Copy link
Contributor

meirish commented Dec 11, 2018

@diegosainz great! l just wanted to clarify that if you click through to policy, then click edit - there is a delete button in the lower right - this should still work. The bug you posted about here is related to the hiding and showing of the context menu, not the actual deletion.

@diegosainz
Copy link
Author

Oh! OK! I misread your comment the first time - it is useful to know. Thank you!

@meirish meirish added this to the 1.0.2 milestone Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants