-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PKI UI may saturate memory #21164
Comments
This is sadly unavoidable due to present design limitations of Vault. The underlying storage backends do not expose any paginated listing capabilities, meaning that the only (storage) list option is a one-shot, all-or-nothing approach. Because of this, no plugins expose any paginated list, count, or otherwise interruptible list operations. This results in the same behavior, here exposed via the UI, but also present via API or CLI, just with different sizes of records causing problems. If you were to replace this with KV instead (with 100k+ entries in a single folder), the same behavior would be replicated there. (Perhaps yes, the new UI's LIST endpoint has a lower number than some other mounts or the older version, fundamentally its the same limitation, regardless of RAM or CPU constraints, even 5k isn't really a usable number of certs to have on a single page). Thus fundamentally, this is a storage shortcoming and until that can be addressed, it is perhaps best to avoid large LIST endpoints in the UI. But for users with fewer entries, the LIST interface is generally useful, so it remains. |
I wanted to link this ticket as it may help with any slow loading due to DOM rendering. This does not fix the issues mentioned by @cipherboy. The UI team has added pagination to the certificate's view and others in the PKI secret engine. Because this is a front-end implementation of pagination (e.g. we still can't limit the number of records the API sends us), this will only help ease the burden of the DOM rendering all the records. The fix was backported to 1.14.x |
I'm facing a similar issue on the transit key management API (transit API). I understand the storage limitation and the need to a one-shot approach in its current implementation. |
@outscale-fba Thank you for this comment! Could you open a new issue with the aforementioned details in the feature request? We're collecting all issues that relate to pagination and the larger number of issues we have, including this, the easier it will be to get the work considered and prioritized. |
Thanks for your reply @hellobontempo. |
Describe the bug
Having a lot of certificates in the PKI (~95600 certificates), using hold UI it works and we can navigate through pages.
But on the newer UI listing certificates takes many Go of RAM (until I kill it), doing the same with less certificates shows
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The page load, and has it has infinite scrolling, it should load pages of certificates as we scroll.
Environment:
vault status
): 1.13.1vault version
): Vault v1.13.3 (cgo)Additional context
I "only" have 16Go of RAM + 4Go of zram
The text was updated successfully, but these errors were encountered: