Adding private ip address reference to azurerm network interface #6538

Felivel · 2016-05-08T18:02:32Z

Adding private ip address reference
Updating the docs.

Felivel · 2016-05-08T18:05:32Z

I am working on creating the test for this PR.

stack72 · 2016-05-09T00:06:38Z

Please let me know when you are happy for this to go on review. We hope to release 0.6.16 tomorrow (Monday) and this would be a nice addition to it :)

Paul

* adding private ip address reference * Updating the docs.

Felivel · 2016-05-09T01:43:24Z

Hello @stack72, Please review my change.

I have added an extra attribute called private_ip_address to the root of the azurerm_network_interface schema, in order to be able to access the private ip directly from the terraform configuration.
E.g.: ${azurerm_network_interface.test.private_ip_address}"

Is there way to access an attribute of an attribute? or are we limited to TYPE.NAME.ATTRIBUTE?

Thanks.

Felivel · 2016-05-09T04:13:59Z

I have done testing with a private build and have integrated the changes to my workflows. Everything seems to be working fine.

stack72 · 2016-05-09T10:36:28Z

builtin/providers/azurerm/resource_arm_network_interface_card.go

+	if iface.IPConfigurations != nil && len(*iface.IPConfigurations) > 0 {
+		var privateIPAddress *string
+		for _, ipConfig := range *iface.IPConfigurations {
+			privateIPAddress = ipConfig.Properties.PrivateIPAddress


we are ranging over a collection here and adding each private ip address in an IPConfig to the same string variable

Should the schema have private_ip_address as a List? Or can we guarantee that only 1 private IP will be in place?

At the moment we can only specify one ip configuration.
Azure/azure-sdk-for-go#259

Maybe we can pick the primary ip configuration once we are able to multiple configurations.

Ok, if there is only 1, then we shouldn't range over right now

We should do something like this:

if iface.IPConfigurations != nil && len(*iface.IPConfigurations) > 0 { var privateIPAddress *string if iface.IPConfigurations[0] != nil { privateIPAddress = iface.IPConfigurations[0].Properties.PrivateIPAddress } }

Then leave a note in place referencing that Azure SDK issue where only 1 NIC is allowed - thoughts?

Looks good. I tried doing that but I was getting some errors. I will try it again.

I hit the same problem as last time.

builtin/providers/azurerm/resource_arm_network_interface_card.go:264: invalid operation: iface.IPConfigurations[0] (type *[]network.InterfaceIPConfiguration does not support indexing)

Should I assign the pointer value to a variable and try like that?

Hi @Felivel

The issue here is that you cannot index when a pointer is in play. So it has to be dereferrenced like this:

(*iface.IPConfigurations)[0].Properties.PrivateIPAddress

Ok, I will push the change in a moment.

stack72 · 2016-05-09T10:37:42Z

Hi @Felivel

I have a few questions inline. Once answered, we should be able to merge this.

P.

stack72 · 2016-05-09T10:38:36Z

builtin/providers/azurerm/resource_arm_network_interface_card.go

@@ -53,6 +53,12 @@ func resourceArmNetworkInterface() *schema.Resource {
 				Computed: true,
 			},

+			"private_ip_address": &schema.Schema{


We are only using this part of the schema in the Read func. Is this not allowed to be set specifically? If not, then we can just make it Computed, and remove optional

Removing optional attribute from private_ip_address, this element is only being used in the read.

Change this to a loop when Azure/azure-sdk-for-go#259 is fixed

stack72 · 2016-05-09T14:21:03Z

Hi @Felivel

this looks great :)

At the end of a Terraform run, I can now get the following:

output "private_ip" {
    value = "${azurerm_network_interface.test.private_ip_address}"
}

Outputs:

  private_ip = 10.0.2.4

…hicorp#6538) * Adding private ip address reference * adding private ip address reference * Updating the docs. * Removing optional attrib from private_ip_address Removing optional attribute from private_ip_address, this element is only being used in the read. * Selecting the first element instead of using a loop for now. Change this to a loop when Azure/azure-sdk-for-go#259 is fixed

ghost · 2020-04-26T01:53:40Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

stack72 added enhancement provider/azurerm labels May 8, 2016

stack72 changed the title ~~Adding private ip address reference to azurerm network interface~~ [WIP] Adding private ip address reference to azurerm network interface May 8, 2016

Felivel force-pushed the master branch from faeb834 to b623727 Compare May 8, 2016 20:59

Adding private ip address reference

0725e7a

* adding private ip address reference * Updating the docs.

Felivel force-pushed the master branch from b623727 to 0725e7a Compare May 9, 2016 01:25

Felivel changed the title ~~[WIP] Adding private ip address reference to azurerm network interface~~ Adding private ip address reference to azurerm network interface May 9, 2016

stack72 reviewed May 9, 2016
View reviewed changes

stack72 mentioned this pull request May 9, 2016

azurerm - private ip not visible when assigned dynamically #6549

Closed

Felivel added 2 commits May 9, 2016 08:24

Removing optional attrib from private_ip_address

b378c22

Removing optional attribute from private_ip_address, this element is only being used in the read.

Selecting the first element instead of using a loop for now.

0587611

Change this to a loop when Azure/azure-sdk-for-go#259 is fixed

stack72 merged commit 156d291 into hashicorp:master May 9, 2016

AlexBevan mentioned this pull request Jan 17, 2018

Adding private ip address reference to azurerm application gateway hashicorp/terraform-provider-azurerm#711

Closed

ghost locked and limited conversation to collaborators Apr 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding private ip address reference to azurerm network interface #6538

Adding private ip address reference to azurerm network interface #6538

Felivel commented May 8, 2016

Felivel commented May 8, 2016 •

edited

Loading

stack72 commented May 9, 2016

Felivel commented May 9, 2016 •

edited

Loading

Felivel commented May 9, 2016 •

edited

Loading

stack72 May 9, 2016

Felivel May 9, 2016 •

edited

Loading

stack72 May 9, 2016

Felivel May 9, 2016

Felivel May 9, 2016

stack72 May 9, 2016

Felivel May 9, 2016

stack72 commented May 9, 2016

stack72 May 9, 2016

Felivel May 9, 2016

stack72 commented May 9, 2016

ghost commented Apr 26, 2020

Adding private ip address reference to azurerm network interface #6538

Adding private ip address reference to azurerm network interface #6538

Conversation

Felivel commented May 8, 2016

Felivel commented May 8, 2016 • edited Loading

stack72 commented May 9, 2016

Felivel commented May 9, 2016 • edited Loading

Felivel commented May 9, 2016 • edited Loading

Choose a reason for hiding this comment

Felivel May 9, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stack72 commented May 9, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stack72 commented May 9, 2016

ghost commented Apr 26, 2020

Felivel commented May 8, 2016 •

edited

Loading

Felivel commented May 9, 2016 •

edited

Loading

Felivel commented May 9, 2016 •

edited

Loading

Felivel May 9, 2016 •

edited

Loading