refresh fails if AWS Route53 zone already deleted

[ashb]

This is probably similar to #4047 but for Route53 records and zones.

How I hit this problem in practice was not by deleting anything manually but by just using terraform destroy:

• terraform plan -destroy -out destroy.plan

• terraform apply destroy.plan -- this failed half way through with aws_subnet.databases-subnet: Error deleting subnet: timeout while waiting for state to become 'destroyed'

• I tried to run terraform plan -destroy again and get this error mesage:

  Error refreshing state: 4 error(s) occurred:
  
  * aws_route53_record.registry_dns: NoSuchHostedZone: The specified hosted zone does not exist.
          status code: 404, request id: dd456a5b-9cd1-11e5-b2c8-178933496bcb
  * aws_route53_record.marathon_dns.0: NoSuchHostedZone: The specified hosted zone does not exist.
          status code: 404, request id: dd86b9a9-9cd1-11e5-8801-79758f4904fa
  * aws_route53_record.marathon_dns.2: NoSuchHostedZone: The specified hosted zone does not exist.
          status code: 404, request id: ddaa6df8-9cd1-11e5-853f-0b7d26528b7c
  * aws_route53_record.marathon_dns.1: NoSuchHostedZone: The specified hosted zone does not exist.
          status code: 404, request id: dda05c7a-9cd1-11e5-bb36-ef7ee1b36da7
  

To reproduce:

• Create this resource

provider "aws" {
    region     = "eu-west-1"
}
resource "aws_route53_zone" "test" {
    name   = "terraformrepropo.local"
    comment = "Terraform bug reproduce case"
}

resource "aws_route53_record" "public_ssh" {
    zone_id = "${aws_route53_zone.test.id}"
    name    = "test"
    type    = "A"
    ttl     = "300"
    records = ["127.0.0.1"]
}

• Go into the AWS console and delete the test record set, and then also delete the terraformrepropo.local zone.
• Run terraform refresh or terraform plan -destroy
• You should see output like this:

aws_route53_zone.test: Refreshing state... (ID: Z1EM87IEBLNEE5)
aws_route53_record.public_ssh: Refreshing state... (ID: Z1EM87IEBLNEE5_test_A)
Error refreshing state: 1 error(s) occurred:

* aws_route53_record.public_ssh: NoSuchHostedZone: The specified hosted zone does not exist.
        status code: 404, request id: 8acb4ddf-9cd3-11e5-bb30-2ba8f9088e65

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.