From 036535d38ff226dc0684a5addbf51413b7a829b3 Mon Sep 17 00:00:00 2001 From: tmshn Date: Tue, 2 May 2017 13:46:59 +0900 Subject: [PATCH] provider/google: Added network check with basic config in TestAccComputeInstanceGroup_basic --- .../google/resource_compute_instance_group_test.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/builtin/providers/google/resource_compute_instance_group_test.go b/builtin/providers/google/resource_compute_instance_group_test.go index 5f1ea5201d28..29ecc9bcdf63 100644 --- a/builtin/providers/google/resource_compute_instance_group_test.go +++ b/builtin/providers/google/resource_compute_instance_group_test.go @@ -14,12 +14,13 @@ import ( func TestAccComputeInstanceGroup_basic(t *testing.T) { var instanceGroup compute.InstanceGroup var instanceName = fmt.Sprintf("instancegroup-test-%s", acctest.RandString(10)) + var networkName = "default" projs := []string{ "GOOGLE_PROJECT", "GCLOUD_PROJECT", "CLOUDSDK_CORE_PROJECT", } - var network = fmt.Sprintf("https://www.googleapis.com/compute/v1/projects/%s/global/networks/default", multiEnvSearch(projs)) + var network = fmt.Sprintf("https://www.googleapis.com/compute/v1/projects/%s/global/networks/%s", multiEnvSearch(projs), networkName) resource.Test(t, resource.TestCase{ PreCheck: func() { testAccPreCheck(t) }, @@ -27,10 +28,12 @@ func TestAccComputeInstanceGroup_basic(t *testing.T) { CheckDestroy: testAccComputeInstanceGroup_destroy, Steps: []resource.TestStep{ resource.TestStep{ - Config: testAccComputeInstanceGroup_basic(instanceName, network), + Config: testAccComputeInstanceGroup_basic(instanceName, networkName), Check: resource.ComposeTestCheckFunc( testAccComputeInstanceGroup_exists( "google_compute_instance_group.basic", &instanceGroup), + testAccComputeInstanceGroup_hasCorrectNetwork( + "google_compute_instance_group.basic", network, &instanceGroup), testAccComputeInstanceGroup_exists( "google_compute_instance_group.empty", &instanceGroup), testAccComputeInstanceGroup_exists( @@ -251,7 +254,7 @@ func testAccComputeInstanceGroup_basic(instance, network string) string { } network_interface { - network = "default" + network = "%s" } } @@ -297,7 +300,7 @@ func testAccComputeInstanceGroup_basic(instance, network string) string { name = "https" port = "8443" } - }`, instance, instance, instance, instance, network) + }`, instance, network, instance, instance, instance, network) } func testAccComputeInstanceGroup_update(instance string) string {