New resource: vsphere_compute_cluster_host_group #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancluever
added
enhancement
vancluever
force-pushed
the
f-vsphere-cluster-host-group-resource
branch
from
a949d66 to
d70ea1a
Compare
Copied/updated from vsphere_compute_cluster_vm_group. Not much to change. Tests and docs to follow.
Resource is now functional, docs next.
Copy/paste problems :P
Docs are complete, resource is ready for PR barring any necessary final edits.
Some minor corrections, and also adding warning blurbs to both the host group and cluster group resources.
vancluever
force-pushed
the
f-vsphere-cluster-host-group-resource
branch
from
d70ea1a to
5c99bd3
Compare
paultyng
approved these changes
May 10, 2018
| func resourceVSphereComputeClusterHostGroupImport(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) { | ||
| var data map[string]string | ||
| if err := json.Unmarshal([]byte(d.Id()), &data); err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
add some additional context on this err before returning?
There was a problem hiding this comment.
This will just return the JSON error which will hopefully be clear enough to the user. I think there are a couple of other resources that have similar import patterns that don't necessarily include any additional error context, so might as well just leave it for consistency for now.
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the other group resource, which manages hosts, and is mainly used in the vm/host affinity rules.
This sets the ground work for the cluster rules to be added now.