New resource: vsphere_drs_vm_override #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the vsphere_drs_vm_override resource, which can be used to specify a VM override for DRS. We used the vsphere_storage_drs_vm_override as a skeleton for most of the work involved here, allowing this resource to be developed pretty quickly. Tests and docs are pending.
Tests are done for the resource now and are functional. Docs are next!
This adds the documentation for vsphere_drs_vm_override, also making a small schema correction as well.
vancluever
added
enhancement
bill-rich
approved these changes
May 2, 2018
| "github.com/vmware/govmomi/vim25/types" | ||
| ) | ||
|
|
||
| const resourceVSphereDrsVMOverrideName = "vsphere_drs_vm_override" |
There was a problem hiding this comment.
Not sure which convention we're going with, but SDRS has all letters capitalized, while Drs is only doing the first.
There was a problem hiding this comment.
Yeah, this is intentional as the camel casing versus full capitalisation helps to distinguish where things are: - resourceVSphereDrsVMOverride versus resourceVSphereDRSVMOverride. This is done in the upcoming HA resource as well.
EDIT: I actually see what you are talking about now. I will make the edits.
resourceVSphereDrsVMOverride is now resourceVSphereDRSVMOverride to be consistent with the SDRS VM override.
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
vsphere_drs_vm_overrideresource, which can be used to control overrides for DRS and automation levels for virtual machines within DRS (compute) clusters.This is one of three compute-related VM override resources. The other two, which will be following in future PRs, are:
These are separated as they are separate fields in the vSphere API's
ClusterConfigSpecEx/ClusterConfigInfoEx. Having them as separate resources simplifies the implementation, allowing us to look up each set of overrides in as a cluster/VM composite key, returning just the involved structure, versus having to consolidate all three and return them all at once. It also facilitates granularity in that if someone wants to provide a DRS override but does not care to supply HA overrides, they don't have to. In addition,vsphere_dpm_host_override, as its title would suggest, involves hosts and not VMs.