r/virtual_machine: Switch ContainerView search to use manual filter

[vancluever]

There seems like there is possibly a bug in RetrieveWithFilter when it
comes to MO's with missing keys and the function returning a false
positive for the object in question. This has caused issues with the VM
search functionality where duplicate UUID errors will be returned for
VMs with UUIDs that are otherwise unique within vSphere inventory if
there are orphaned VMs in inventory that lack a configuration (as in the
whole config data object is missing).

This bug applies to the provider when being used with vSphere 6.0 and
earlier.

[vancluever]

Ref: #382

@johnjelinek and anyone else having this issue can you give this fix a shot?

Thanks!

[den-is]

@vancluever just tell how to test it? I don't know

[vancluever]

Hey @den-is, you will want to follow the instructions here. Make sure you switch to the b-vm-containerview-search branch first before you build (git checkout b-vm-containerview-search after cloning).

[johnjelinek]

@vancluever: I get the same error from this version

[johnjelinek]

nvm, I was forgetting a step to push in the new binary. Works on my machine 😄 ! It's slow though:

time terraform plan   
17.59s user 1.60s system 75% cpu 25.555 total

[vancluever]

Great! Glad that it works!

Just making one more change - would you be able to test it? It's a speed improvement. :)

[vancluever]

@johnjelinek if you can check the latest commit here, that would be great!

I actually tested the different searches on the vcsim with 1000 VMs and there definitely was a slowdown when all properties were being retrieved. Since we only need the UUID to check it, we can skip the rest, which brings it back closer to near RetrieveWithFitler speeds.

[johnjelinek]

much better, thanks!

time terraform plan
1.57s user 0.68s system 24% cpu 9.320 total

[vancluever]

Awesome! Merging now 👍