r/virtual_machine: Block disk names from coming from computed values #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to create computed attributes in the graph for a new computed value test.
... in the *graph*. Basically, this means that the value has to be present at plan time. This comes out in the diff in that if the value is blank, we assume it's computed as it's a required field and would need to be specified.
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in the graph. Basically, this means that the value has to be
present at plan time. This comes out in the diff in that if the value is
blank, we assume it's computed as it's a required field and would need
to be specified.
Fixes #320. Our disk diff logic right now is highly dependent on name at plan time so we can't support this currently. When the changes in #295 ultimately get implemented, this won't be such a big deal as the disk name won't need to rely so much on the VM name.