Connect virtual cdrom on boot

[palesiak]

When cloning a VM, and specifying a virtual cdrom device, it doesn't boot with it connected.

I'm not sure if this PR is the appropriate approach -- maybe it should be a config parameter, however as it currently stands the virtual cdrom functionality does not mimic what was previously in 0.4.x, where it would automatically be connected.

[vancluever]

Hey @palesiak, this looks good I think. I'm just going to add a test and I think we will be good to go.

I don't necessarily want to expose connection flags right now - I'd rather it be either you want a CD device or you don't - same for most virtual devices.

Thanks for catching this one too!

[vancluever]

Just posting test results:

Before (failing on clone as expected):

=== RUN   TestAccResourceVSphereVirtualMachine
=== RUN   TestAccResourceVSphereVirtualMachine/cdrom
=== RUN   TestAccResourceVSphereVirtualMachine/clone_with_cdrom
--- FAIL: TestAccResourceVSphereVirtualMachine (134.50s)
    --- PASS: TestAccResourceVSphereVirtualMachine/cdrom (19.20s)
    --- FAIL: TestAccResourceVSphereVirtualMachine/clone_with_cdrom (115.29s)
    	testing.go:503: Step 0 error: Check failed: Check 2/2 error: expected CDROM device to be connected

After (both pass):

=== RUN   TestAccResourceVSphereVirtualMachine
=== RUN   TestAccResourceVSphereVirtualMachine/cdrom
=== RUN   TestAccResourceVSphereVirtualMachine/clone_with_cdrom
--- PASS: TestAccResourceVSphereVirtualMachine (143.07s)
    --- PASS: TestAccResourceVSphereVirtualMachine/cdrom (19.49s)
    --- PASS: TestAccResourceVSphereVirtualMachine/clone_with_cdrom (123.58s)

👍 Thanks again @palesiak - merging now!

[palesiak]

cool, thanks for adding the test cases @vancluever 🚀