r/host_virtual_switch: Support a switch with no NICs #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is basically done in vSphere by supplying no bridge to the config spec - in our configuration, we were passing the bridge with zero nics, which is an invalid configuration. This change just nils out the bridge after expansion if there are no NICs. We have also added some diff-time validation to make sure that any NIC specified in the active or standby list is a NIC configured on the bridge to avoid errors at apply time.
|
Thanks @mbfrahry! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically done in vSphere by supplying no bridge to the config
spec - in our configuration, we were passing the bridge with zero nics,
which is an invalid configuration.
This change just nils out the bridge after expansion if there are no
NICs. We have also added some diff-time validation to make sure that any
NIC specified in the active or standby list is a NIC configured on the
bridge to avoid errors at apply time.
Fixes #210.