tags: Ensure complete removal of tags is working #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagsClientIfDefined was checking to see if the tags client was defined as a condition to loading up the tags client for Create and Update operations. While this generally worked for adding the tags to new resources and changing tags when necessary, it was not working for complete tag removal due to its reliance on GetOk, which fails if a field is removed from config completely. This fixes tagsClientIfDefined so that it checks both the old and new incarnations of the tags argument to make sure that both are empty before passing on loading the tags client.
|
Thanks @mbfrahry! |
vancluever
added a commit
that referenced
this pull request
Oct 11, 2017
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tagsClientIfDefinedwas checking to see if the tags client was definedas a condition to loading up the tags client for
CreateandUpdateoperations. While this generally worked for adding the tags to new
resources and changing tags when necessary, it was not working for
complete tag removal due to its reliance on
GetOk, which fails if afield is removed from config completely.
This fixes
tagsClientIfDefinedso that it checks both the old and newincarnations of the
tagsargument to make sure that both are emptybefore passing on loading the tags client.