WIP: add domain as dns suffix option #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like the related issue: #24 |
|
Hey @mjrider - smoke tested this, all looks good! Merging now. Thanks for the contribution! |
vancluever
added a commit
that referenced
this pull request
Oct 11, 2017
The new description is a lot more specific on the current behaviour of domain versus dns_suffixes.
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default virtual machines get customized with vsphere.local as dns lookup suffix. While most of the time there is a better alternative, being the domain name of the VM. This adds a check for this alternative
This was suggested a while ago and lived as a stash in my git folder.
rebased it, and pushed it.
I can test it tomorrow at work.