New resource and data source: vsphere_tag #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like UpdateTag needed to be added too. This is now done, will re-vendor off of master if something comes up.
This adds the vsphere_tag resource, which can be used to set up and manage tags. Data source and docs will be coming soon. Note that the import for this function takes a JSON string, as both tags and categories can support special characters, so there is not much for us to really use as a delimiter.
This is the data source counterpart to the vsphere_tag resource, similar in workflow to the vsphere_tag_category data source.
vancluever
added
enhancement
mbfrahry
approved these changes
Sep 25, 2017
website/docs/r/tag.html.markdown
Outdated
| * `name` - (String, required) The display name of the tag. The name must be | ||
| unique within its category. | ||
| * `description` - (String, optional) A description for the tag. | ||
| * `category_id` - (String, required, forces new resource) The unique identifier |
There was a problem hiding this comment.
Thoughts on putting the required arguments next to each other?
|
Applied doc change and pushed - thanks @mbfrahry! Merging now |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
vsphere_tagresource and data source, allowing the ability to manage and pull in tags.Next step is adding the ability to tag all of the objects in the provider that can be tagged!
PS: This also includes an update to the vic package which was also missing tag update support.