Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with kubernetes_node_taint #2077

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Apr 17, 2023

Description

Fix an issue when updating taint in the kubernetes_node_taint resource does not update the ID in the state file.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS="-count 1 -run ^TestAccKubernetesResourceNodeTaint"

=== RUN   TestAccKubernetesResourceNodeTaint_basic
--- PASS: TestAccKubernetesResourceNodeTaint_basic (2.17s)
=== RUN   TestAccKubernetesResourceNodeTaint_MultipleBasic
--- PASS: TestAccKubernetesResourceNodeTaint_MultipleBasic (4.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-kubernetes/kubernetes	7.864s

Release Note

Release note for CHANGELOG:

`resource/kubernetes_node_taint`: Fix an issue when updating taint does not update the ID in the state file.

References

N/A.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@arybolovlev arybolovlev marked this pull request as ready for review April 17, 2023 16:13
@arybolovlev arybolovlev requested a review from a team as a code owner April 17, 2023 16:13
@arybolovlev arybolovlev merged commit e49fa7e into main Apr 18, 2023
@arybolovlev arybolovlev deleted the fix-taint-resource branch April 18, 2023 06:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants