Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'kubernetes_job' and 'kubernetes_job_v1' docs #1997

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Update 'kubernetes_job' and 'kubernetes_job_v1' docs #1997

merged 1 commit into from
Feb 13, 2023

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Feb 13, 2023 •
edited
Loading

Description

Update kubernetes_job and kubernetes_job_v1 docs with spec.completion_mode.

Acceptance tests

N/A.

Release Note

Release note for CHANGELOG:

`resource/kubernetes_job`: Add documentation for the attribute `spec.completion_mode`.
`resource/kubernetes_job_v1`: Add documentation for the attribute `spec.completion_mode`.

References

Fix: #1494

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@arybolovlev arybolovlev requested a review from a team as a code owner February 13, 2023 14:45
alexsomesan
alexsomesan approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arybolovlev arybolovlev merged commit e69c999 into main Feb 13, 2023
@arybolovlev arybolovlev deleted the update-job-resource-docs branch February 13, 2023 15:07
BBBmau pushed a commit that referenced this pull request Feb 16, 2023
@arybolovlev @BBBmau
Update 'kubernetes_job' and 'kubernetes_job_v1' docs with 'spec.compl…
7095c42 
…etion_mode' (#1997)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Job completionMode (beta in 1.22)
2 participants
@arybolovlev @alexsomesan