Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unknown Value in Manifest Diff #966

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Fix Unknown Value in Manifest Diff #966

merged 3 commits into from
Oct 11, 2022

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Oct 5, 2022

Description

Fixes #965

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

Crash Fix: Fix Unknown Value in Manifest Diff

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from jrhouston October 5, 2022 17:03
@jrhouston jrhouston force-pushed the fix-Unknown-Manifest branch 2 times, most recently from 2deb15b to 69a7578 Compare October 6, 2022 04:21
@jrhouston
Copy link
Contributor

Thanks for opening this @BBBmau. I've pushed a regression test to this branch. If you uncomment the fix and run that test you'll see it catches the bug described in the original issue.

@BBBmau BBBmau merged commit 390b76c into main Oct 11, 2022
@BBBmau BBBmau deleted the fix-Unknown-Manifest branch October 11, 2022 15:44
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.7.0 provider fails to create new helm_release with values referencing known-after-apply attributes
2 participants