Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perpetual diff when setting version to empty string #1246

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

jrhouston
Copy link
Contributor

Description

Fixes #1236

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jrhouston jrhouston requested a review from a team as a code owner September 5, 2023 19:36
@jrhouston jrhouston changed the title fix perpetual diff when setting version to empty string Fix perpetual diff when setting version to empty string Sep 5, 2023
@github-actions github-actions bot added the size/S label Sep 5, 2023
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with a minor comment.

{
Config: testAccHelmReleaseConfigEmptyVersion(testResourceName, namespace, name),
Check: resource.ComposeAggregateTestCheckFunc(
resource.TestCheckResourceAttr("helm_release.test", "metadata.0.name", name),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move "helm_release.test" to a variable resourceName?

@jrhouston jrhouston merged commit 7aacef7 into main Sep 6, 2023
15 checks passed
@jrhouston jrhouston deleted the fix-blank-version branch September 6, 2023 15:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm release metadata computation cause helm_release to be updated in-place
2 participants