Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload Identity config on autopilot cluster error message is not self-explanatory #9892

Closed
tgirier opened this issue Aug 24, 2021 · 4 comments
Assignees
Labels
bug forward/review In review; remove label to forward service/container

Comments

@tgirier
Copy link

tgirier commented Aug 24, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.0.5
on darwin_arm64

  • provider registry.terraform.io/hashicorp/google v3.65.0

Affected Resource(s)

  • google_container_cluster

Terraform Configuration Files

# Copy-paste your Terraform configurations here.
#
# For large Terraform configs, please use a service like Dropbox and share a link to the ZIP file.
# For security, you can also encrypt the files using our GPG public key:
#    https://www.hashicorp.com/security
#
# If reproducing the bug involves modifying the config file (e.g., apply a config,
# change a value, apply the config again, see the bug), then please include both:
# * the version of the config before the change, and
# * the version of the config after the change.

resource "google_container_cluster" "cluster" {
  name     = "demo-cluster"
  project  = var.project
  location = var.region

  network    = var.network.self_link
  subnetwork = var.cluster_subnet.self_link

  enable_autopilot = true

  ip_allocation_policy {
    cluster_secondary_range_name  = "cluster-pods-subnet"
    services_secondary_range_name = "cluster-services-subnet"
  }

  master_authorized_networks_config {
    cidr_blocks {
      display_name = "home"
      cidr_block   = var.authorized_cidr
    }
  }

  master_auth {
    username = ""
    password = ""

    client_certificate_config {
      issue_client_certificate = false
    }
  }

  vertical_pod_autoscaling {
    enabled = true
  }

  workload_identity_config {
    identity_namespace = "${var.project}.svc.id.goog"
  } 

}

Debug Output

Panic Output

Expected Behavior

Workload identity is enabled by default when using the autopilot feature.
The error message simply states that workload identity conflicts with autopilot.
Therefore we don't know if the conflict is due to the fact that it is not supported on autopilot clusters or if it is enabled by default.

Actual Behavior

The displayed error message when the configuration is applied is :

│ Error: ConflictsWith
│
│   with module.cluster.google_container_cluster.cluster,
│   on cluster/cluster.tf line 1, in resource "google_container_cluster" "cluster":
│    1: resource "google_container_cluster" "cluster" {
│
│ "workload_identity_config": conflicts with enable_autopilot

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
@tgirier tgirier added the bug label Aug 24, 2021
@megan07 megan07 self-assigned this Aug 24, 2021
@megan07
Copy link
Contributor

megan07 commented Aug 25, 2021

Hi @tgirier ! Sorry for the confusion here. My understanding is that, because it's enabled by default, we don't want to set it in the config (see this comment on shielded nodes). Let me know if this helps or if you disagree with this assessment and I can dig a bit deeper into it.
Thanks!

@megan07
Copy link
Contributor

megan07 commented Sep 27, 2021

Hi @tgirier ! Is this still an issue?

@megan07
Copy link
Contributor

megan07 commented Oct 4, 2021

Closing assuming this is no longer an issue

@megan07 megan07 closed this as completed Oct 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
@github-actions github-actions bot added service/container forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug forward/review In review; remove label to forward service/container
Projects
None yet
Development

No branches or pull requests

2 participants