Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of google_iap_client as a DATASOURCE #6482

Closed
Backstreets opened this issue May 28, 2020 · 4 comments · Fixed by GoogleCloudPlatform/magic-modules#4429, hashicorp/terraform-provider-google-beta#2951 or #8450

Comments

@Backstreets
Copy link

Backstreets commented May 28, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

I'd like to be able to use a google_iap_client as a datasource, without having to import it to Terraform.
The goal is to avoid destroying the iap client if I do a terraform destroy of my infra.
The info obtained from the datasource (oauth2_client_id, oauth2_client_secret, oauth2_client_secret_sha256) is to be used in the iap block of google_compute_backend_service.

New or Affected Resource(s)

Potential Terraform Configuration

References

https://www.terraform.io/docs/providers/google/r/iap_client.html
https://www.terraform.io/docs/providers/google/r/compute_backend_service.html

Mentioned in:
#6074

We also discussed this briefly in #6074 (comment)

@oswalya
Copy link

oswalya commented Jul 14, 2020

This would really be a helpful implementation.
As long as google does not provide the API to fully automate the oauth2 client configuration, at least with this approach we could reuse the data within our infrastructure automation.

Any news on this so far?

@hadim
Copy link

hadim commented Nov 23, 2020

I also could benefit from this in case it helps prioritizing.

@upodroid
Copy link
Contributor

upodroid commented Jan 20, 2021

@rileykarson We can close this issue.

The API doesn't return the oauth client secret and ID for security reasons after it has been created. You'll need to retrieve it from the UI. Therefore, a datasource in terraform will not work.

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.