Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more stackdriver service monitoring datasources #6429

Closed
1 of 3 tasks
emilymye opened this issue May 20, 2020 · 3 comments · Fixed by GoogleCloudPlatform/magic-modules#4222, hashicorp/terraform-provider-google-beta#2730 or #7847

Comments

@emilymye
Copy link
Contributor

emilymye commented May 20, 2020

Add ability to add datasources for:

  • cloud endpoints
  • cluster istio (API docs say deprecated but)
  • mesh istio

The actual work of creating datasources is small (see example) but the initial test resources that create the related monitoring services have to be bootstrapped separately

Finishing work from #5058

@emilymye emilymye added this to the Near-Term Goals milestone May 20, 2020
@emilymye emilymye self-assigned this May 20, 2020
@emilymye emilymye removed their assignment Jun 9, 2020
@edwardmedia edwardmedia self-assigned this Oct 30, 2020
@edwardmedia
Copy link
Contributor

edwardmedia commented Nov 2, 2020

For mesh istio, is it meshUid for meshid ?

From https://cloud.google.com/monitoring/api/ref_v3/rest/v3/services

JSON representation
--
{   "meshUid": string,   "serviceNamespace": string,   "serviceName": string }

From https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/

meshId | string | The unique identifier for the service mesh All control planes running in the same service mesh should specify the same mesh ID. Mesh ID is used to label telemetry reports for cases where telemetry from multiple meshes is mixed together.

@edwardmedia
Copy link
Contributor

@ghost
Copy link

ghost commented Dec 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.