Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Container port in google_cloud_run_service #6232

Closed
thnee opened this issue Apr 28, 2020 · 2 comments
Closed

Add Container port in google_cloud_run_service #6232

thnee opened this issue Apr 28, 2020 · 2 comments

Comments

@thnee
Copy link

thnee commented Apr 28, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

According to this documentation, the cloud run service has a first class configuration field called Container port in the GUI, --port in CLI, and containerPort in YAML.

https://cloud.google.com/run/docs/configuring/containers#configure-port

But in this documentation, it seems to be completely missing.

https://www.terraform.io/docs/providers/google/r/cloud_run_service.html

Let's please add it?

New or Affected Resource(s)

  • google_cloud_run_service

Potential Terraform Configuration

Probably something like this.

resource "google_cloud_run_service" "default" {
  name = "..."

  template {
    spec {
      containers {
        image = "..."
        containerPort = 80
      }
    }
  }
}
@ghost ghost added the enhancement label Apr 28, 2020
@thnee
Copy link
Author

thnee commented Apr 28, 2020

Duplicate of #5539

@thnee thnee closed this as completed Apr 28, 2020
@ghost
Copy link

ghost commented May 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant