-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to selecting N1 or N2 machine type when using custom machine types. #4650
Comments
So just specify it, what's the problem? |
Hi, When specifying
It appears as if terraform is looking for the machine type as it hasn't recognised that it is indeed, custom. Previously to create custom pools we wouldn't add the |
I would hold off making any changes to terraform to support this just yet, we have an open case with google about the partial support for n2 on gke and have fed back these api differences They’ve just replied saying the implementation is still under development and the eta for it to be “working” is the 11th November |
So to be super clear about the problem as i'm not really getting anywhere with GCP support: to provision n1 (as it is currently), on Intel SkyLake, you would do:
Therefore logically to get CascadeLake, you'd expect:
However this doesn't work, the pool provisions but the nodes never start with an error about If you create a pool in the GUI (which works), the machine type is actually prefixed with
Terraform fails with the following error:
|
Hey @danawillow sorry to be tagging you directly but you've helped me out a lot historically :-) Not really sure where to turn here, not much engagement here and GCP support when I highlight the API convention changes to them :-( As it stands, you can't use N2 (Cascade Lake) instances on GKE with Terraform because of this. |
Hey @Stono, I'm not sure this is something we need to explicitly add (it should just work out of the box), but we can probably document how to do it. Does it work with gcloud, and if so, can you run the command with |
Hi, I'm experiencing this exact same error. The generated custom machine type is "n2-custom-4-7168". When this string is used in Terraform as a machine_type, it looks like TF instead tries to use a standard machine type with that name. |
I am closing this issue as now i am able to create instances with custom type |
Given that @Qvazar's comment is from earlier today, I think that means they're still facing the issue :) @Qvazar, do you have debug logs (https://www.terraform.io/docs/internals/debugging.html) from a run of Terraform that failed with that machine type? |
Hi @danawillow, |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Community Note
Description
Google introduced new machine types - N2 for predefined and custom machine types.
When creating a a compute instance or node pool for a K8S cluster which is using a custom machine type I want to be able to specify which machine type I would like.
New or Affected Resource(s)
Potential Terraform Configuration
References
https://cloud.google.com/compute/docs/instances/creating-instance-with-custom-machine-type#n2_custom_machine_types
The text was updated successfully, but these errors were encountered: