Feature Request: Support BigQuery clustering

[migibert]

Hi,

It would be great if we could create BigQuery tables with setting clustering columns.
Documentation: https://cloud.google.com/bigquery/docs/creating-clustered-tables

Affected Resource(s)

• google_bigquery_table

[migibert]

Hi,

I wanted to work on this feature, but it looks like the bigquery library in vendors is not the latest one.

I tried to upgrade it using govendor update google.golang.org/api/bigquery/v2 and I can observe changes on the following files:

• vendor/google.golang.org/api/bigquery/v2/bigquery-api.json
• vendor/google.golang.org/api/bigquery/v2/bigquery-gen.go
• vendor/vendor.json

So it looked good to me but now the provider does not build because of this error:

make build
==> Checking that code complies with gofmt requirements...
go install
# github.com/terraform-providers/terraform-provider-google/vendor/google.golang.org/api/bigquery/v2
vendor/google.golang.org/api/bigquery/v2/bigquery-gen.go:5466:25: assignment mismatch: 3 variables but 2 values
vendor/google.golang.org/api/bigquery/v2/bigquery-gen.go:5471:2: undefined: gensupport.SetGetBody
GNUmakefile:9: recipe for target 'build' failed
make: *** [build] Error 2

Can you give me some directions about how to fix this ? Maybe I did not upgrade the library correctly ?

[nat-henderson]

Govendor is a little odd. You probably wanted govendor fetch instead of govendor update. Does it work if you do that?

[migibert]

Hey, thanks for your help. Sadly, I tried with fetch command and met the same problem...

[nat-henderson]

Ah... In the docs for that package:

This package is DEPRECATED. Use package cloud.google.com/go/bigquery instead.

I'm not sure if that's really going to make this easier, though. It seems like the API is completely different, and switching would require a complete rewrite of the existing code. I think it would be tough to take that on.

[nat-henderson]

I'll see if I can figure out how we can get that fixed... :)

[migibert]

Thank you ! I saw the deprecation warning but hoped I could still use this library... :'(

[Cidan]

Hey folks,

Update on this? I'm getting ready to write this, but don't want to step on any toes.

[nat-henderson]

I definitely did not find a solution - please, feel free. :)

[pashashiz]

Hello, any updates on this?

[nat-henderson]

I believe this is unlocked now that the BigQuery team has generated a REST client, but I don't believe that anyone is currently working on this - we'd definitely accept a community contribution, and we'll put it on our radar for prioritization as well.

[pashashiz]

What about the @Cidan's pull request? Any idea why that was closed.

[nat-henderson]

It became obsolete when we moved this repo to be fully generated in Magic Modules - it could be reopened against that repo, I believe.

[matt-gen]

Thought I'd pile on support for this enhancement so I don't have to create these tables manually outside of TF.

[nathadfield]

Adding some further weight behind this. Not supporting clustering puts TF at a disadvantage.

[ashuclh]

Any updates on this?
Requirement is we need to specify for every table the partition field and the clustering fields

[kvas-damian]

Another PR trying to address this issue: #4223

[kvas-damian]

I think the issue is solved by #4223

[megan07]

Thanks @migibert for opening this issue. It's been closed with #4223 and has been released in 2.14.0.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!