Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple API's with same terraform resource product namespace #12572

Closed
sandmman opened this issue Sep 15, 2022 · 2 comments
Closed

Support multiple API's with same terraform resource product namespace #12572

sandmman opened this issue Sep 15, 2022 · 2 comments
Labels
enhancement forward/review In review; remove label to forward service/gkeonprem

Comments

@sandmman
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

We're creating a new set of terraform resources using mmv1 for the GKE On-Prem API. It's a separate API (gkeonprem.googleapis.com) from GKE (container.googleapis.com); however, we'd like the resource name to have the container prefix rather than our service name. Something like: google_container_bare_metal_cluster.

Following the MMV1 docs, results in google_gkeonprem_bare_metal_cluster. As far as I can tell, the resource name is taken from the 'name' field in products/gkeonprem/api.yaml file and the snakecased resource.

The Container product and product folder is already taken by GKE. We'd like to be able to override our product name without it conflicting with generated files from GKE.

When we attempt to change the Product.name field in the mmv1 api.yaml file. We end up with the error:

generate': google-beta/container_operation.go was already modified during this run.. check to see if there is both a .go and .go.erb version of this file (RuntimeError)

New or Affected Resource(s)

  • google_gkeonprem_bare_metal_cluster
  • google_gkeonprem_bare_metal_node_pool

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

@rileykarson
Copy link
Collaborator

It's intentional that services are split by service endpoint in their provider representations, and merging multiple endpoints into a single product prefix is undesirable.

Note that this is possible technically with legacy_name, but that's a feature used to support handwritten resources alongside generated one with a consistent naming convention when the handwritten resources differ from the generator default.

@rileykarson rileykarson closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
@github-actions github-actions bot added service/gkeonprem forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement forward/review In review; remove label to forward service/gkeonprem
Projects
None yet
Development

No branches or pull requests

2 participants