Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: 'azurerm_iothub_dps' #5336

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

jackbatzner
Copy link
Contributor

Add the 'azurerm_iothub_dps' data source.

I chose not to include the SKU property as I didn't think it was too critical for a data source. I imagine that the more important values would be the ones included. I can easily add it if you think it's required.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @Brunhil

@tombuildsstuff tombuildsstuff added this to the v1.41.0 milestone Jan 8, 2020
@tombuildsstuff
Copy link
Contributor

Test passes:

Screenshot 2020-01-08 at 08 04 07

@tombuildsstuff tombuildsstuff merged commit 0e68290 into hashicorp:master Jan 8, 2020
tombuildsstuff added a commit that referenced this pull request Jan 8, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 7, 2020
@jackbatzner jackbatzner deleted the data_iothub_dps branch March 14, 2020 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants