r/shared_image_version - support for the storage_account_type property

[tombuildsstuff]

This PR incorporates and supersedes #4865 by making the storage_account_type field computed & removing the List assertions from the tests since it's a Set.

Supersedes #4865
Fixes #4833

[tombuildsstuff]

The tests for this in master are broken due to a change in the API - whilst they're still broken in this PR we're going to fix that post-merge so that this doesn't get blocked behind the upcoming refactor:

------- Stdout: -------
=== RUN   TestAccAzureRMSharedImageVersion_basic
=== PAUSE TestAccAzureRMSharedImageVersion_basic
=== CONT  TestAccAzureRMSharedImageVersion_basic
--- FAIL: TestAccAzureRMSharedImageVersion_basic (2475.42s)
    testing.go:630: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: errors during apply: Error deleting Shared Image Gallery "acctestsig191218170806559421" (Resource Group "acctestRG-191218170806559421"): compute.GalleriesClient#Delete: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="CannotDeleteResource" Message="Can not delete resource before nested resources are deleted."

Whilst that's clearly not ideal - once the refactor's done we can circle around and take a look at fixing this - else we're going to have a merge conflict/to start afresh here

[katbyte]

LGTM 👍

[ghost]

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!