Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_eventgrid_domain - Export primary_access_key and secondary_access_key #4876

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

hbuckle
Copy link
Contributor

@hbuckle hbuckle commented Nov 14, 2019

No description provided.

@ghost ghost added the size/XS label Nov 14, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbuckle this looks good but it's worth adding these attributes to the docs as well

@katbyte katbyte added this to the v1.37.0 milestone Nov 15, 2019
@ghost ghost added the documentation label Nov 15, 2019
@hbuckle
Copy link
Contributor Author

hbuckle commented Nov 15, 2019

@mbfrahry - yes indeed, docs updated

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Add eventgrid domain access keys azurerm_eventgrid_domain - Export primary_access_key and secondary_access_key Nov 15, 2019
@mbfrahry mbfrahry merged commit b6f0fa5 into hashicorp:master Nov 15, 2019
mbfrahry added a commit that referenced this pull request Nov 15, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants