Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Custom Timeouts in Custom Refresh Func's #4838

Merged
merged 2 commits into from
Nov 8, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Whilst passing through I noticed that the Custom Refresh Func's weren't reusing the custom timeouts present on the resource; as such this should allow users to fully configure custom timeouts for resources, which enables #22 - when that functionality is feature toggled on

I've split a couple of the refresh funcs out to make this logic simpler too

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 9930bf3 into master Nov 8, 2019
tombuildsstuff added a commit that referenced this pull request Nov 8, 2019
@tombuildsstuff tombuildsstuff deleted the f/custom-refresh-timeouts branch November 12, 2019 19:07
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants