Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support minor version of java in azurerm_app_service settings #4779

Merged
merged 4 commits into from
Nov 17, 2019

Conversation

aczelandi
Copy link
Contributor

Fixes #4318

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @aczelandi

Thanks for this PR :)

Taking a look through this is looking good - if we can fix up the minor comments then this otherwise LGTM 👍

Thanks!

website/docs/r/app_service.html.markdown Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service_test.go Outdated Show resolved Hide resolved
azurerm/helpers/azure/app_service.go Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @aczelandi

Thanks for pushing those changes - taking a look through this LGTM 👍

I've kicked off the tests and there's a couple of failures with the Java 11 tests - but if we can fix those up (which I think is just setting the correct minor version) then we should be good
👍

Screenshot 2019-11-01 at 11 25 07

Thanks!

azurerm/resource_arm_app_service_test.go Outdated Show resolved Hide resolved
@ghost ghost added size/M and removed size/L labels Nov 3, 2019
@aczelandi
Copy link
Contributor Author

hi @tombuildsstuff, good catch, thanks!
It seems Azure does not support minor versions for Java 11 (I tried all existing versions and keep getting the same Bad Request).
I updated the docs/tests to reflects this.

I am not sure though about TestAccAzureRMAppService_linuxFxVersion, could you send me a screenshot with details? This one does not seem related to Java.

@ghost ghost removed the waiting-response label Nov 3, 2019
@katbyte
Copy link
Collaborator

katbyte commented Nov 3, 2019

@aczelandi,

I wouldn't worry about TestAccAzureRMAppService_linuxFxVersion, it's been failing on master for almost a month now, but here it is:

------- Stdout: -------
=== RUN   TestAccAzureRMAppService_linuxFxVersion
=== PAUSE TestAccAzureRMAppService_linuxFxVersion
=== CONT  TestAccAzureRMAppService_linuxFxVersion
--- FAIL: TestAccAzureRMAppService_linuxFxVersion (86.49s)
    testing.go:569: Step 0 error: errors during apply:
        
        Error: Error creating App Service "acctestAS-191103035435793800" (Resource Group "acctestRG-191103035435793800"): web.AppsClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="The parameter LinuxFxVersion has an invalid value." Details=[{"Message":"The parameter LinuxFxVersion has an invalid value."},{"Code":"BadRequest"},{"ErrorEntity":{"Code":"BadRequest","ExtendedCode":"01007","Message":"The parameter LinuxFxVersion has an invalid value.","MessageTemplate":"The parameter {0} has an invalid value.","Parameters":["LinuxFxVersion"]}}]
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test491210449/main.tf line 18:
          (source code not available)
        
        
FAIL

------- Stderr: -------
2019/11/03 03:54:35 [DEBUG] Registering Data Sources for "Compute"..
2019/11/03 03:54:35 [DEBUG] Registering Resources for "Compute"..

@aczelandi
Copy link
Contributor Author

aczelandi commented Nov 10, 2019

hi @tombuildsstuff,

could you try to rerun the tests and see if they were fixed?

@tombuildsstuff
Copy link
Contributor

@aczelandi tests look good - thanks for this:

Screenshot 2019-11-17 at 11 13 02

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @aczelandi

@tombuildsstuff tombuildsstuff merged commit 02db1c8 into hashicorp:master Nov 17, 2019
tombuildsstuff added a commit that referenced this pull request Nov 17, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Specifying Java minor version for azurerm_app_service resource
3 participants