Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new data source azurerm_data_factory #4517

Merged
merged 9 commits into from
Oct 4, 2019

Conversation

tracypholmes
Copy link
Contributor

@tracypholmes tracypholmes commented Oct 4, 2019

Fixes #4421.

Tests pass.
image

…vider-azurerm into f/data_source_data_factory-new
@ghost ghost added size/L and removed size/XL labels Oct 4, 2019
@tracypholmes tracypholmes added this to the v1.36.0 milestone Oct 4, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple minor comments i've left inline LGTM 👍

azurerm/data_source_arm_data_factory.go Show resolved Hide resolved
azurerm/data_source_arm_data_factory.go Show resolved Hide resolved
website/docs/d/data_factory.html.markdown Outdated Show resolved Hide resolved
@ghost ghost added size/XL and removed size/L labels Oct 4, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor things but this otherwise LGTM 👍

website/docs/d/data_factory.html.markdown Outdated Show resolved Hide resolved
website/docs/d/data_factory.html.markdown Outdated Show resolved Hide resolved
azurerm/data_source_arm_data_factory.go Outdated Show resolved Hide resolved
@tracypholmes tracypholmes changed the title [WIP] Added new data source azurerm_data_factory Added new data source azurerm_data_factory Oct 4, 2019
@tracypholmes tracypholmes merged commit 1d2f611 into master Oct 4, 2019
@tracypholmes tracypholmes deleted the f/data_source_data_factory-new branch October 4, 2019 18:35
tracypholmes added a commit that referenced this pull request Oct 4, 2019
tracypholmes added a commit that referenced this pull request Oct 4, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 4, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Data Source: Azure Data Factory
3 participants