Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault - waiting for the DNS to propagate #401

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Ensuring the Key Vault is available via DNS before completing provisioning

Fixes an issue where creating a Key Vault Key/Secret failed intermittently if the DNS hadn't finished replicating

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screen shot 2017-10-06 at 11 03 36

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 9737dba into master Oct 6, 2017
@tombuildsstuff tombuildsstuff deleted the key-vault-polling branch October 6, 2017 13:32
tombuildsstuff added a commit that referenced this pull request Oct 6, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants