Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/storage_blob: making metadata computed #3842

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 12, 2019

Fixes TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach

------- Stdout: -------
=== RUN   TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
=== PAUSE TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
=== CONT  TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
--- FAIL: TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach (548.77s)
    testing.go:568: Step 2 error: After applying this step and refreshing, the plan was not empty:

        DIFF:

        UPDATE: azurerm_storage_blob.test
          attempts:                                         "1" => "1"
          content_type:                                     "application/octet-stream" => "application/octet-stream"
          id:                                               "https://accsa190712152930379829.blob.core.windows.net/vhds/datadisk1.vhd" => "https://accsa190712152930379829.blob.core.windows.net/vhds/datadisk1.vhd"
          metadata.microsoftazurecompute_diskid:            "12713d7a-226f-4e95-8b45-91fd268582cd" => ""
          metadata.microsoftazurecompute_diskname:          "datadisk1.vhd" => ""
          metadata.microsoftazurecompute_disksizeingb:      "45" => ""
          metadata.microsoftazurecompute_disktype:          "DataDisk" => ""
          metadata.microsoftazurecompute_resourcegroupname: "acctestRG-190712152930379829" => ""
          metadata.microsoftazurecompute_vmname:            "acctvm-190712152930379829" => ""
          name:                                             "datadisk1.vhd" => "datadisk1.vhd"
          parallelism:                                      "8" => "8"
          resource_group_name:                              "acctestRG-190712152930379829" => "acctestRG-190712152930379829"
          size:                                             "0" => "0"
          source_uri:                                       "https://accsa190712152930379829.blob.core.windows.net/vhds/myosdisk1.vhd" => "https://accsa190712152930379829.blob.core.windows.net/vhds/myosdisk1.vhd"
          storage_account_name:                             "accsa190712152930379829" => "accsa190712152930379829"
          storage_container_name:                           "vhds" => "vhds"
          type:                                             "page" => "page"
          url:                                              "https://accsa190712152930379829.blob.core.windows.net/vhds/datadisk1.vhd" => "https://accsa190712152930379829.blob.core.windows.net/vhds/datadisk1.vhd"

Fixes TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach

```
------- Stdout: -------
=== RUN   TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
=== PAUSE TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
=== CONT  TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
--- FAIL: TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach (548.77s)
    testing.go:568: Step 2 error: After applying this step and refreshing, the plan was not empty:

        DIFF:

        UPDATE: azurerm_storage_blob.test
          attempts:                                         "1" => "1"
          content_type:                                     "application/octet-stream" => "application/octet-stream"
          id:                                               "https://accsa190712152930379829.blob.core.windows.net/vhds/datadisk1.vhd" => "https://accsa190712152930379829.blob.core.windows.net/vhds/datadisk1.vhd"
          metadata.microsoftazurecompute_diskid:            "12713d7a-226f-4e95-8b45-91fd268582cd" => ""
          metadata.microsoftazurecompute_diskname:          "datadisk1.vhd" => ""
          metadata.microsoftazurecompute_disksizeingb:      "45" => ""
          metadata.microsoftazurecompute_disktype:          "DataDisk" => ""
          metadata.microsoftazurecompute_resourcegroupname: "acctestRG-190712152930379829" => ""
          metadata.microsoftazurecompute_vmname:            "acctvm-190712152930379829" => ""
          name:                                             "datadisk1.vhd" => "datadisk1.vhd"
          parallelism:                                      "8" => "8"
          resource_group_name:                              "acctestRG-190712152930379829" => "acctestRG-190712152930379829"
          size:                                             "0" => "0"
          source_uri:                                       "https://accsa190712152930379829.blob.core.windows.net/vhds/myosdisk1.vhd" => "https://accsa190712152930379829.blob.core.windows.net/vhds/myosdisk1.vhd"
          storage_account_name:                             "accsa190712152930379829" => "accsa190712152930379829"
          storage_container_name:                           "vhds" => "vhds"
          type:                                             "page" => "page"
          url:                                              "https://accsa190712152930379829.blob.core.windows.net/vhds/datadisk1.vhd" => "https://accsa190712152930379829.blob.core.windows.net/vhds/datadisk1.vhd"
```
@tombuildsstuff
Copy link
Contributor Author

Storage Tests pass:

Screenshot 2019-07-12 at 17 09 10

Virtual Machine test passes:

Screenshot 2019-07-12 at 17 09 32

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit d76e303 into master Jul 12, 2019
@tombuildsstuff tombuildsstuff deleted the b/storage-blob-metadata branch July 12, 2019 19:20
tombuildsstuff added a commit that referenced this pull request Jul 12, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 12, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants