Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies 'go.opencensus.io/exemplar' broken #3638

Closed
kevinkirkup opened this issue Jun 11, 2019 · 8 comments
Closed

Dependencies 'go.opencensus.io/exemplar' broken #3638

kevinkirkup opened this issue Jun 11, 2019 · 8 comments
Assignees
Labels
dependencies upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Milestone

Comments

@kevinkirkup
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

~v1.28.0 - v1.30.1
Not sure when it started...

Affected Resource(s)

N/A Occurs when loading provider SDK

Terraform Configuration Files

N/A SDK

Debug Output

package github.com/pureport/terraform-provider-pureport/pureport (test)
	imports github.com/terraform-providers/terraform-provider-azurerm/azurerm
	imports github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/resources
	imports github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2016-02-01/resources
	imports github.com/Azure/go-autorest/autorest
	imports github.com/Azure/go-autorest/autorest/adal
	imports github.com/Azure/go-autorest/tracing
	imports contrib.go.opencensus.io/exporter/ocagent
	imports go.opencensus.io/exemplar: unknown import path "go.opencensus.io/exemplar": cannot find module providing package go.opencensus.io/exemplar

Panic Output

Expected Behavior

go get github.com/pureport/terraform-providers/terraform-provider-azurerm should be able to download all dependencies.

Actual Behavior

go.opencensus.io/exemplar isn't found.

Steps to Reproduce

  1. Create a project that imports the provider SDK
  2. go get github.com/pureport/terraform-providers/terraform-provider-azurerm
  3. Build it.

Important Factoids

References

  • #0000
@kevinkirkup
Copy link
Author

kevinkirkup commented Jun 11, 2019

Looks like github.com/Azure/go-autorest isn't using go mod and so the dependency tree is broken.
The current provider is pointing to github.com/Azure/go-autorest@v11.7.0 but may need to be updated to a newer version.

@katbyte katbyte self-assigned this Jul 9, 2019
@katbyte katbyte added dependencies upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Jul 9, 2019
@katbyte katbyte added this to the v1.32.0 milestone Jul 9, 2019
@tombuildsstuff
Copy link
Contributor

Upstream issue: Azure/go-autorest#413

@kevinkirkup
Copy link
Author

Override with autorest v12 seems to work as expected.

@tamalsaha
Copy link

Azure/go-autorest#431 seemed to work for me.

@tombuildsstuff
Copy link
Contributor

This should be fixed via the upcoming v0.7.0 of hashicorp/go-azure-helpers

@tombuildsstuff tombuildsstuff modified the milestones: v1.33.0, v1.34.0 Aug 19, 2019
@tombuildsstuff
Copy link
Contributor

This should have been fixed via #4166 - closing

@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

No branches or pull requests

4 participants