User Assigned Identity: add corresponding data source #3343
Conversation
logachev
commented
Apr 30, 2019
logachev
commented
- Created data source for User Assigned Identity
- Added relevant tests
- Updated documentation
| }) | ||
| } | ||
|
|
||
| func testEqualResourceAttr(dataSourceName string, resourceName string, attrName string) resource.TestCheckFunc { |
There was a problem hiding this comment.
I noticed that in other data source tests there is no any checks that data source resource contains same information as a resource.
Do you think this is valuable to move this function to some shared place and reuse in other data source tests?
There was a problem hiding this comment.
There is definitely value and a place for that: helpers/tf/acctest.go package would be perfect.
| }) | ||
| } | ||
|
|
||
| func testEqualResourceAttr(dataSourceName string, resourceName string, attrName string) resource.TestCheckFunc { |
There was a problem hiding this comment.
There is definitely value and a place for that: helpers/tf/acctest.go package would be perfect.
|
This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.28.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
