Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding validation to azurerm_key_vault's name #270

Merged
merged 2 commits into from
Aug 24, 2017
Merged

Adding validation to azurerm_key_vault's name #270

merged 2 commits into from
Aug 24, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Adding validation to the Name for the azurerm_key_vault resource - so that we catch errors at plan rather than during apply

Fixes #265

@tombuildsstuff tombuildsstuff mentioned this pull request Aug 24, 2017
Closed
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 120m -run TestAccAzureRMKeyVault_
=== RUN   TestAccAzureRMKeyVault_importBasic
--- PASS: TestAccAzureRMKeyVault_importBasic (73.40s)
=== RUN   TestAccAzureRMKeyVault_name
--- PASS: TestAccAzureRMKeyVault_name (0.00s)
=== RUN   TestAccAzureRMKeyVault_basic
--- PASS: TestAccAzureRMKeyVault_basic (58.12s)
=== RUN   TestAccAzureRMKeyVault_update
--- PASS: TestAccAzureRMKeyVault_update (89.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	221.074s

grubernaut
grubernaut reviewed Aug 24, 2017
View reviewed changes
azurerm/resource_arm_key_vault.go
@@ -207,7 +209,7 @@ func resourceArmKeyVaultRead(d *schema.ResourceData, meta interface{}) error {
d.SetId("")
return nil
}
return fmt.Errorf("Error making Read request on Azure KeyVault %s: %s", name, err)
return fmt.Errorf("Error making Read request on Azure KeyVault %s: %+v", name, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 nice

grubernaut
grubernaut approved these changes Aug 24, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 08a20cd into master Aug 24, 2017
@tombuildsstuff tombuildsstuff deleted the key-vault branch August 24, 2017 14:21
tombuildsstuff added a commit that referenced this pull request Aug 24, 2017
@tombuildsstuff
Updating to include #270
7d58ce3
tombuildsstuff added a commit that referenced this pull request Aug 25, 2017
@tombuildsstuff
fixing the formatting for #270
cbe13ce
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation of the Key Vault's name is not executed when it is terraform plan
2 participants
@tombuildsstuff @grubernaut