Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_dev_center_dev_box_definition #26307

Merged
merged 9 commits into from
Jul 9, 2024

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jun 12, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support new resource azurerm_dev_center_dev_box_definition.

API Reference: https://github.com/Azure/azure-rest-api-specs/blob/259fe9abaed3b55b600dc82d79323f046501e87f/specification/devcenter/resource-manager/Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L2342

Overview: https://learn.microsoft.com/en-gb/azure/dev-box/overview-what-is-microsoft-dev-box

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
--- PASS: TestAccDevCenterDevBoxDefinition_basic (1124.40s)
--- PASS: TestAccDevCenterDevBoxDefinition_requiresImport (1010.20s)
--- PASS: TestAccDevCenterDevBoxDefinition_update (1310.47s)
--- PASS: TestAccDevCenterDevBoxDefinition_complete (1092.29s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • New Resource: azurerm_dev_center_dev_box_definition

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Contributor

@ms-zhenhua ms-zhenhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @neil-yechenwei ,

Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

@neil-yechenwei
Copy link
Contributor Author

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look.

@neil-yechenwei
Copy link
Contributor Author

@ms-zhenhua , below is the test result I just now triggered.

image

@ms-zhenhua
Copy link
Contributor

@neil-yechenwei, thank you for your updates. LGTM~

@neil-yechenwei neil-yechenwei marked this pull request as ready for review June 24, 2024 07:52

resp, err := clients.DevCenter.V20230401.DevBoxDefinitions.Get(ctx, *id)
if err != nil {
return nil, fmt.Errorf("reading %s: %+v", *id, err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return nil, fmt.Errorf("reading %s: %+v", *id, err)
return nil, fmt.Errorf("retrieving %s: %+v", *id, err)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

return nil, fmt.Errorf("reading %s: %+v", *id, err)
}

return utils.Bool(resp.Model != nil), nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return utils.Bool(resp.Model != nil), nil
return pointer.To(resp.Model != nil), nil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


* `dev_center_id` - (Required) The ID of the associated Dev Center. Changing this forces a new resource to be created.

* `image_reference_id` - (Required) The ID of the image for Dev Center Dev Box Definition.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `image_reference_id` - (Required) The ID of the image for Dev Center Dev Box Definition.
* `image_reference_id` - (Required) The ID of the image for the Dev Center Dev Box Definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


* `image_reference_id` - (Required) The ID of the image for Dev Center Dev Box Definition.

* `sku_name` - (Required) The name of the SKU for Dev Center Dev Box Definition.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `sku_name` - (Required) The name of the SKU for Dev Center Dev Box Definition.
* `sku_name` - (Required) The name of the SKU for the Dev Center Dev Box Definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

An existing Dev Center Dev Box Definition can be imported into Terraform using the `resource id`, e.g.

```shell
terraform import azurerm_dev_center_dev_box_definition.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.DevCenter/devcenters/dc1/devboxdefinitions/et1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casing here?

Suggested change
terraform import azurerm_dev_center_dev_box_definition.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.DevCenter/devcenters/dc1/devboxdefinitions/et1
terraform import azurerm_dev_center_dev_box_definition.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.DevCenter/devCenters/dc1/devBoxDefinitions/et1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@neil-yechenwei
Copy link
Contributor Author

@stephybun , thanks for the comments. I updated PR. Below is the test result I just now triggered.

image

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei LGTM 👍

@stephybun stephybun merged commit 5262232 into hashicorp:main Jul 9, 2024
34 checks passed
@github-actions github-actions bot added this to the v3.112.0 milestone Jul 9, 2024
stephybun added a commit that referenced this pull request Jul 9, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jul 15, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.111.0&#34; to &#34;3.112.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.112.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.112.0&#xA;FEATURES:&#xA;&#xA;*
New Data Source: `azurerm_elastic_san_volume_snapshot`
([#26439](https://github.com/hashicorp/terraform-provider-azurerm/issues/26439))&#xA;*
New Resource: `azurerm_dev_center_dev_box_definition`
([#26307](https://github.com/hashicorp/terraform-provider-azurerm/issues/26307))&#xA;*
New Resource: `azurerm_dev_center_environment_type`
([#26291](https://github.com/hashicorp/terraform-provider-azurerm/issues/26291))&#xA;*
New Resource: `azurerm_virtual_machine_restore_point`
([#26526](https://github.com/hashicorp/terraform-provider-azurerm/issues/26526))&#xA;*
New Resource: `azurerm_virtual_machine_restore_point_collection`
([#26526](https://github.com/hashicorp/terraform-provider-azurerm/issues/26526))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20240710.1114656` of
`github.com/hashicorp/go-azure-sdk`
([#26588](https://github.com/hashicorp/terraform-provider-azurerm/issues/26588))&#xA;*
dependencies: updating to `v0.70.0` of `go-azure-helpers`
([#26601](https://github.com/hashicorp/terraform-provider-azurerm/issues/26601))&#xA;*
`containerservice`: updating the Fleet resources to use API Version
`2024-04-01`
([#26588](https://github.com/hashicorp/terraform-provider-azurerm/issues/26588))&#xA;*
Data Source: `azurerm_network_service_tags` - extend validation for
`service` to allow `AzureFrontDoor.Backend`, `AzureFrontDoor.Frontend`,
and `AzureFrontDoor.FirstParty`
([#26429](https://github.com/hashicorp/terraform-provider-azurerm/issues/26429))&#xA;*
`azurerm_api_management_identity_provider_aad` - support for the
`client_library` property
([#26093](https://github.com/hashicorp/terraform-provider-azurerm/issues/26093))&#xA;*
`azurerm_api_management_identity_provider_aadb2c` - support for the
`client_library` property
([#26093](https://github.com/hashicorp/terraform-provider-azurerm/issues/26093))&#xA;*
`azurerm_dev_test_virtual_network` - support for the
`shared_public_ip_address` property
([#26299](https://github.com/hashicorp/terraform-provider-azurerm/issues/26299))&#xA;*
`azurerm_kubernetes_cluster` - support for the `certificate_authority`
block under the `service_mesh_profile` block
([#26543](https://github.com/hashicorp/terraform-provider-azurerm/issues/26543))&#xA;*
`azurerm_linux_web_app` - support the value `8.3` for the `php_version`
property
([#26194](https://github.com/hashicorp/terraform-provider-azurerm/issues/26194))&#xA;*
`azurerm_machine_learning_compute_cluster` - the `identity` property can
now be updated
([#26404](https://github.com/hashicorp/terraform-provider-azurerm/issues/26404))&#xA;*
`azurerm_web_application_firewall_policy` - support for the
`JSChallenge` value for
`managed_rules.managed_rule_set.rule_group_override.rule_action`
([#26561](https://github.com/hashicorp/terraform-provider-azurerm/issues/26561))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* Data Source: `azurerm_communication_service` -
`primary_connection_string`, `primary_key`,
`secondary_connection_string` and `secondary_key` are marked as
Sensitive
([#26560](https://github.com/hashicorp/terraform-provider-azurerm/issues/26560))&#xA;*
`azurerm_app_configuration_feature` - fix issue when updating the
resource without an existing `targeting_filter`
([#26506](https://github.com/hashicorp/terraform-provider-azurerm/issues/26506))&#xA;*
`azurerm_backup_policy_vm` - split create and update function to fix
lifecycle - ignore
([#26591](https://github.com/hashicorp/terraform-provider-azurerm/issues/26591))&#xA;*
`azurerm_backup_protected_vm` - split create and update function to fix
lifecycle - ignore
([#26583](https://github.com/hashicorp/terraform-provider-azurerm/issues/26583))&#xA;*
`azurerm_communication_service` - the `primary_connection_string`,
`primary_key`, `secondary_connection_string`, and `secondary_key`
properties are now sensitive
([#26560](https://github.com/hashicorp/terraform-provider-azurerm/issues/26560))&#xA;*
`azurerm_mysql_flexible_server_configuration` - add locks to prevent
conflicts when deleting the resource
([#26289](https://github.com/hashicorp/terraform-provider-azurerm/issues/26289))&#xA;*
`azurerm_nginx_deployment` - changing the `frontend_public.ip_address`,
`frontend_private.ip_address`, `frontend_private.allocation_method`, and
`frontend_private.subnet_id` now creates a new resource
([#26298](https://github.com/hashicorp/terraform-provider-azurerm/issues/26298))&#xA;*
`azurerm_palo_alto_local_rulestack_rule` - correctl read the `protocol`
property on read when the `protocol_ports` property is configured
([#26510](https://github.com/hashicorp/terraform-provider-azurerm/issues/26510))&#xA;*
`azurerm_servicebus_namespace` - parse the identity returned by the API
insensitively before setting into state
([#26540](https://github.com/hashicorp/terraform-provider-azurerm/issues/26540))&#xA;&#xA;DEPRECATIONS:&#xA;&#xA;*
`azurerm_servicebus_queue` - `enable_batched_operations`,
`enable_express` and `enable_partitioning` are superseded by
`batched_operations_enabled`, `express_enabled` and
`partitioning_enabled`
([#26479](https://github.com/hashicorp/terraform-provider-azurerm/issues/26479))&#xA;*
`azurerm_servicebus_subscription` - `enable_batched_operations` has been
superseded by `batched_operations_enabled`
([#26479](https://github.com/hashicorp/terraform-provider-azurerm/issues/26479))&#xA;*
`azurerm_servicebus_topic` - `enable_batched_operations`,
`enable_express` and `enable_partitioning` are superseded by
`batched_operations_enabled`, `express_enabled` and
`partitioning_enabled`
([#26479](https://github.com/hashicorp/terraform-provider-azurerm/issues/26479))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/319/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Copy link

github-actions bot commented Aug 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants