azurerm_disk_encryption_set: Support for the managed_hsm_key_id property

[Botje]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds support for HSMs to the disk encryption set resource.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

I did not run any tests because deploying Managed HSMs exceeds the budget of my personal playground subscription.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• disk_encryption_set - support for managed HSMs [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #21470

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[Botje]

"service/disk" seems an appropriate label, too.

[katbyte]

Thanks for the pr @Botje - looks like we have a test failure:

------- Stdout: -------
=== RUN   TestAccDiskEncryptionSet_disablePurgeProtection
=== PAUSE TestAccDiskEncryptionSet_disablePurgeProtection
=== CONT  TestAccDiskEncryptionSet_disablePurgeProtection
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        
        Error: validating Key Vault "acctestkv-jknzr" (Resource Group "acctestRG-240618213622132222") for Disk Encryption Set: Purge Protection must be enabled
        
          with azurerm_disk_encryption_set.test,
          on terraform_plugin_test.tf line 105, in resource "azurerm_disk_encryption_set" "test":
         105: resource "azurerm_disk_encryption_set" "test" {
        
--- FAIL: TestAccDiskEncryptionSet_disablePurgeProtection (328.83s)
FAIL

[katbyte]

Thanks for the pr @Botje - looks like we have a test failure:

------- Stdout: -------
=== RUN   TestAccDiskEncryptionSet_disablePurgeProtection
=== PAUSE TestAccDiskEncryptionSet_disablePurgeProtection
=== CONT  TestAccDiskEncryptionSet_disablePurgeProtection
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        
        Error: validating Key Vault "acctestkv-jknzr" (Resource Group "acctestRG-240618213622132222") for Disk Encryption Set: Purge Protection must be enabled
        
          with azurerm_disk_encryption_set.test,
          on terraform_plugin_test.tf line 105, in resource "azurerm_disk_encryption_set" "test":
         105: resource "azurerm_disk_encryption_set" "test" {
        
--- FAIL: TestAccDiskEncryptionSet_disablePurgeProtection (328.83s)
FAIL

[Botje]

Hi @katbyte,

--- FAIL: TestAccDiskEncryptionSet_disablePurgeProtection (328.83s)

This was an asymmetry I noticed in the code: the creation path does not test for purge protection but the update path does. I assumed this was an oversight and implemented the same check for both create and update.
Looking at the git blame output for that specific test, I notice that that actually removed the purge protection check on creation.
I think the proper course of action is then also to remove the purge protection check alltogether.

[katbyte]

Thanks @Botje that makes sense to me and all tests now pass. LGTM

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.