Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_public_ip: renamed public_ip_address_allocation to allocation_method & added missing properties to datasource #2576

Merged
merged 8 commits into from
Jan 8, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Dec 27, 2018

renamed public_ip_address_allocation to allocation_method as it better matches the API & be a bit more clear
datasource was missing multiple properties so added them

Also changed the property to be case sensitive & updated all existing test code & examples to have the proper case

@katbyte katbyte added this to the 1.21.0 milestone Dec 27, 2018
@katbyte katbyte requested a review from a team December 27, 2018 02:27
@ghost ghost added the size/XXL label Dec 27, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.21.0, 2.0.0 Dec 28, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments but this otherwise LGTM 👍

return fmt.Errorf("Cannot specify publicIpAllocationMethod as Static for IPv6 PublicIp")
}
}

if strings.ToLower(string(sku.Name)) == "standard" {
if strings.ToLower(string(ipAllocationMethod)) != "static" {
if strings.ToLower(sku) == "standard" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use strings.EqualFold(sku, "standard") here

website/docs/r/public_ip.html.markdown Outdated Show resolved Hide resolved
website/docs/r/public_ip.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte merged commit a01ed35 into master Jan 8, 2019
@katbyte katbyte deleted the pubip/allocation_method branch January 8, 2019 02:22
katbyte added a commit that referenced this pull request Jan 8, 2019
dghubble added a commit to poseidon/typhoon that referenced this pull request Jan 28, 2019
* azurerm_public_ip (used internally) added a field `allocation_method`
to replace the field `public_ip_address_allocation` (deprecated)
* Require terraform-provider-azurerm v1.21+
* hashicorp/terraform-provider-azurerm#2576
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
@ghost ghost removed the waiting-response label Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants