Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_security_center_setting - SENTINEL is not valid anymore for setting_name #24438

Closed
1 task done
TimoW-Wago opened this issue Jan 9, 2024 · 2 comments · Fixed by #24497
Closed
1 task done
Labels
bug category/casing/constants Resolved with new base layer, upgrading version should fix. service/security-center v/3.x
Milestone

Comments

@TimoW-Wago
Copy link

TimoW-Wago commented Jan 9, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Terraform Version

1.6.4

AzureRM Provider Version

3.86.0

Affected Resource(s)/Data Source(s)

azurerm_security_center_setting

Terraform Configuration Files

resource "azurerm_security_center_setting" "main" {
  setting_name = "SENTINEL"
  enabled      = true
}

Debug Output/Panic Output

Error: parsing "/subscriptions/XXXXXX-XXXX-XXXX/providers/Microsoft.Security/settings/SENTINEL": parsing segment "settingName": expected the segment "settingName" to match one of the values "MCAS, Sentinel, WDATP, WDATP_EXCLUDE_LINUX_PUBLIC_PREVIEW, WDATP_UNIFIED_SOLUTION" but got "SENTINEL"
Operation failed: failed running terraform plan (exit 1)

Expected Behaviour

Terraform plans should run without errors and update the value of name_setting to the new case.

Actual Behaviour

We upgraded from provider version 3.83.0 to 3.86.0 and all Terraform plans fail. The casing of the option setting_name was changed in provider version 3.85.0 and does not accept the old value anymore. Therefore all Terraform runs fail during the plan stage making all changes to update to the new value Sentinel impossible.

Steps to Reproduce

  1. terraform apply using provider version 3.83.0
  2. upgrade provider to 3.86.0
  3. Optional: Change setting_name to new value Sentinel
  4. terraform apply using new provider version

Important Factoids

No response

References

@ziyeqf
Copy link
Contributor

ziyeqf commented Jan 15, 2024

Hi @TimoW-Wago , Thanks for reporting!

I have opened a PR(#24497) for this, once it merged & released it should work. While as SENTINEL is a deprecated value, it's highly recommended to use Sentinel instead of SENTINEL.

For any further questions please leave comments.

Thanks!

@rcskosir rcskosir added category/casing/constants Resolved with new base layer, upgrading version should fix. bug labels Feb 9, 2024
@github-actions github-actions bot added this to the v3.93.0 milestone Feb 20, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug category/casing/constants Resolved with new base layer, upgrading version should fix. service/security-center v/3.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants