new resource: `azurerm_spring_cloud_dynatrace_application_performance_monitoring` #23889

ms-henglu · 2023-11-14T07:27:28Z

…_monitoring`

magodo

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

website/docs/r/spring_cloud_dynatrace_application_performance_monitoring.html.markdown

...vices/springcloud/spring_cloud_dynatrace_application_performance_monitoring_resource_test.go

...l/services/springcloud/spring_cloud_dynatrace_application_performance_monitoring_resource.go

katbyte · 2024-01-08T04:17:58Z

...l/services/springcloud/spring_cloud_dynatrace_application_performance_monitoring_resource.go

+			ValidateFunc: validation.StringIsNotEmpty,
+		},
+
+		"tenant": {


should this be

Suggested change

"tenant": {

"tenant_id": {

or is this different then a standard azure tennant id?

Yes, this is not a standard azure tenant id.

katbyte · 2024-01-08T04:18:34Z

website/docs/r/spring_cloud_dynatrace_application_performance_monitoring.html.markdown

+  tenant_token            = "example-tenant-token"
+  connection_point        = "example-connection-endpoint"


can you use examples that are more realistic here?

katbyte · 2024-01-08T04:22:21Z

...l/services/springcloud/spring_cloud_dynatrace_application_performance_monitoring_resource.go

+			Type:         pluginsdk.TypeString,
+			Required:     true,
+			Sensitive:    true,
+			ValidateFunc: validation.StringIsNotEmpty,


can we do a better job validating this?

I'm afraid that we can't

katbyte · 2024-01-08T04:22:27Z

...l/services/springcloud/spring_cloud_dynatrace_application_performance_monitoring_resource.go

+			Type:         pluginsdk.TypeString,
+			Required:     true,
+			Sensitive:    true,
+			ValidateFunc: validation.StringIsNotEmpty,


This is the token used to authenticated, so we can't validate it.

katbyte · 2024-01-08T04:22:40Z

...l/services/springcloud/spring_cloud_dynatrace_application_performance_monitoring_resource.go

+		"api_url": {
+			Type:         pluginsdk.TypeString,
+			Optional:     true,
+			ValidateFunc: validation.StringIsNotEmpty,


this should be validate as a url?

katbyte · 2024-01-08T04:22:49Z

...l/services/springcloud/spring_cloud_dynatrace_application_performance_monitoring_resource.go

+			Type:         pluginsdk.TypeString,
+			Optional:     true,
+			Sensitive:    true,
+			ValidateFunc: validation.StringIsNotEmpty,


can we properly validate this?

This is a token used to authenticated, so we can't validate it.

katbyte

Could we also apply the more realitic values to the docs?

katbyte · 2024-01-09T16:50:57Z

...vices/springcloud/spring_cloud_dynatrace_application_performance_monitoring_resource_test.go

  environment_id          = "test-environment-id"
  tenant                  = "test-tenant"


what about these values?

katbyte · 2024-01-09T16:54:08Z

...vices/springcloud/spring_cloud_dynatrace_application_performance_monitoring_resource_test.go

@@ -161,10 +161,10 @@ resource "azurerm_spring_cloud_dynatrace_application_performance_monitoring" "te
  spring_cloud_service_id = azurerm_spring_cloud_service.test.id
  globally_enabled        = true
  api_url                 = "https://test-api-url.com"
-  api_token               = "test-api-token"
+  api_token               = "dt0s01.ST2EY72KQINMH574WMNVI7YN.G3DFPBEJYMODIDAEX454M7YWBUVEFOWKPRVMWFASS64NFH52PX6BNDVFFM572RZM"


this might be better as

api_token = "dt0s01.AAAAAAAAAAAAAAAAAAAAAAAA.BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB"

katbyte

Could we also apply the more realitic values to the docs?

ms-henglu · 2024-01-10T05:27:22Z

Hi @katbyte ,

Thanks for the code review! I've updated the tests and doc as suggested. But for the unchanged fields, the realistic values could be random string.

katbyte

Thanks, LGTM 🌴

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.87.0" to "3.88.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.88.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.88.0
FEATURES:

* New Data Source: `azurerm_nginx_deployment` ([#24492](https://github.com/hashicorp/terraform-provider-azurerm/issues/24492))
* New Resource: `azurerm_spring_cloud_dynatrace_application_performance_monitoring` ([#23889](https://github.com/hashicorp/terraform-provider-azurerm/issues/23889))
* New Resource: `azurerm_virtual_machine_run_command` ([#23377](https://github.com/hashicorp/terraform-provider-azurerm/issues/23377))

ENHANCEMENTS:

* dependencies: updating to `v0.20240117.1163544` of `github.com/hashicorp/go-azure-sdk` ([#24481](https://github.com/hashicorp/terraform-provider-azurerm/issues/24481))
* dependencies: updating to `v0.65.1` of `github.com/hashicorp/go-azure-helpers` ([#24479](https://github.com/hashicorp/terraform-provider-azurerm/issues/24479))
* `datashare`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24481](https://github.com/hashicorp/terraform-provider-azurerm/issues/24481))
* `kusto`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24477](https://github.com/hashicorp/terraform-provider-azurerm/issues/24477))
* Data Source: `azurerm_application_gateway` - support for the `trusted_client_certificate.data` property ([#24474](https://github.com/hashicorp/terraform-provider-azurerm/issues/24474))
* `azurerm_service_plan`: refactoring to use `hashicorp/go-azure-sdk` ([#24483](https://github.com/hashicorp/terraform-provider-azurerm/issues/24483))
* `azurerm_container_group` - support for the `priority` property ([#24374](https://github.com/hashicorp/terraform-provider-azurerm/issues/24374))
* `azurerm_mssql_managed_database` - support for the `point_in_time_restore` property ([#24535](https://github.com/hashicorp/terraform-provider-azurerm/issues/24535))
* `azurerm_mssql_managed_instance` - now exports the `dns_zone` attribute ([#24435](https://github.com/hashicorp/terraform-provider-azurerm/issues/24435))
* `azurerm_linux_web_app_slot` - support for setting `python_version` to `3.12` ([#24363](https://github.com/hashicorp/terraform-provider-azurerm/issues/24363))
* `azurerm_linux_web_app` - support for setting `python_version` to `3.12` ([#24363](https://github.com/hashicorp/terraform-provider-azurerm/issues/24363))
* `azurerm_linux_function_app_slot` - support for setting `python_version` to `3.12` ([#24363](https://github.com/hashicorp/terraform-provider-azurerm/issues/24363))
* `azurerm_linux_function_app` - support for setting `python_version` to `3.12` ([#24363](https://github.com/hashicorp/terraform-provider-azurerm/issues/24363))

BUG FIXES:

* `azurerm_application_gateway` - the `components` property within the `url` block is no longer computed ([#24480](https://github.com/hashicorp/terraform-provider-azurerm/issues/24480))
* `azurerm_cdn_frontdoor_route` - prevent an issue where `cdn_frontdoor_origin_path` gets removed on update if unchanged. ([#24488](https://github.com/hashicorp/terraform-provider-azurerm/issues/24488))
* `azurerm_cognitive_account` - fixing support for the `DC0` SKU ([#24526](https://github.com/hashicorp/terraform-provider-azurerm/issues/24526))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1017/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-04-30T02:05:01Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation service/spring size/XL waiting-response labels Nov 14, 2023

new resource: `azurerm_spring_cloud_dynatrace_application_performance…

79a6208

…_monitoring`

ms-henglu force-pushed the ticket-24187298-spring-cloud-apms-dynatrace branch from cd8d3e7 to 79a6208 Compare November 14, 2023 07:32

github-actions bot added waiting-response and removed waiting-response labels Nov 14, 2023

make generate

5486491

github-actions bot removed the waiting-response label Nov 14, 2023

update

fbb153a

magodo added the new-resource label Nov 15, 2023

magodo requested changes Nov 15, 2023

View reviewed changes

github-actions bot added the waiting-response label Nov 15, 2023

update

90e5ceb

github-actions bot removed the waiting-response label Nov 15, 2023

jackofallops self-assigned this Dec 5, 2023

Merge branch 'main' into ticket-24187298-spring-cloud-apms-dynatrace

505e656

github-actions bot added the waiting-response label Dec 28, 2023

update

2be27d6

github-actions bot added waiting-response and removed waiting-response labels Dec 28, 2023

import format

4d95e0d

github-actions bot removed the waiting-response label Jan 3, 2024

katbyte requested changes Jan 8, 2024

View reviewed changes

github-actions bot added the waiting-response label Jan 8, 2024

update validation and tests

0693bea

github-actions bot removed the waiting-response label Jan 8, 2024

katbyte requested changes Jan 9, 2024

View reviewed changes

katbyte added the waiting-response label Jan 9, 2024

update test

662e133

github-actions bot removed the waiting-response label Jan 10, 2024

katbyte approved these changes Jan 15, 2024

View reviewed changes

katbyte merged commit 48783ef into hashicorp:main Jan 15, 2024
33 checks passed

katbyte added a commit that referenced this pull request Jan 15, 2024

Update CHANGELOG.md #23889

b4a414b

github-actions bot added this to the v3.88.0 milestone Jan 15, 2024

github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new resource: `azurerm_spring_cloud_dynatrace_application_performance_monitoring` #23889

new resource: `azurerm_spring_cloud_dynatrace_application_performance_monitoring` #23889

ms-henglu commented Nov 14, 2023

magodo left a comment

katbyte Jan 8, 2024

katbyte Jan 8, 2024

ms-henglu Jan 8, 2024

katbyte Jan 8, 2024

katbyte Jan 8, 2024

ms-henglu Jan 8, 2024

katbyte Jan 8, 2024

ms-henglu Jan 8, 2024

katbyte Jan 8, 2024

katbyte Jan 8, 2024

ms-henglu Jan 8, 2024

katbyte left a comment

katbyte Jan 9, 2024

katbyte Jan 9, 2024

katbyte left a comment

ms-henglu commented Jan 10, 2024

katbyte left a comment

github-actions bot commented Apr 30, 2024

		tenant_token = "example-tenant-token"
		connection_point = "example-connection-endpoint"

		environment_id = "test-environment-id"
		tenant = "test-tenant"

new resource: azurerm_spring_cloud_dynatrace_application_performance_monitoring #23889

new resource: azurerm_spring_cloud_dynatrace_application_performance_monitoring #23889

Conversation

ms-henglu commented Nov 14, 2023

magodo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

ms-henglu commented Jan 10, 2024

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 30, 2024

new resource: `azurerm_spring_cloud_dynatrace_application_performance_monitoring` #23889

new resource: `azurerm_spring_cloud_dynatrace_application_performance_monitoring` #23889