Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_synapse_workspace - add support for azuread_authentication_only #23659

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Oct 23, 2023

Fixes #16002

--- PASS: TestAccSynapseWorkspace_azureAdOnlyAuthentication (956.02s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from 1 comment LGTM 🔐

@@ -183,6 +183,8 @@ The following arguments are supported:

* `sql_administrator_login_password` - (Optional) The Password associated with the `sql_administrator_login` for the SQL administrator. If this is not provided `aad_admin` or `customer_managed_key` must be provided.

* `azure_ad_only_authentication_enabled` - (Optional) Is Azure Active Directory Authentication the only way to authenticate with resources inside this synapse Workspace. Defaults to `false`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have azuread_authentication_only in the provider elsewhere so we might want to use that?

@mbfrahry mbfrahry merged commit f97225e into main Oct 24, 2023
22 checks passed
@mbfrahry mbfrahry deleted the syn-workspace-ad-auth-only branch October 24, 2023 17:22
@mbfrahry mbfrahry changed the title azurerm_synapse_workspace - add support for azure_ad_only_authentication_enabled azurerm_synapse_workspace - add support for azuread_authentication_only Oct 24, 2023
@github-actions github-actions bot added this to the v3.78.0 milestone Oct 24, 2023
mbfrahry added a commit that referenced this pull request Oct 24, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for "Azure Active Directory authentication only" on Synapse Workspace
2 participants