Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_automation_software_update_configuration - fix nil tag in tagsSetting causes create error #19516

Merged
merged 2 commits into from
Dec 2, 2022
Merged

azurerm_automation_software_update_configuration - fix nil tag in tagsSetting causes create error #19516

merged 2 commits into from
Dec 2, 2022

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Dec 1, 2022 •
edited
Loading

a workaround to Fixes: #19454

upstream issue: Azure/azure-rest-api-specs#21719

image

stephybun
stephybun requested changes Dec 1, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu, can we add a test or modify one of the existing ones to validate this workaround?

@wuxu92
Copy link
Contributor Author

wuxu92 commented Dec 2, 2022

Thanks @wuxu, can we add a test or modify one of the existing ones to validate this workaround?

updated the basic test config, and test run pass

--- PASS: TestAccSoftwareUpdateConfiguration_update (159.89s)
PASS

stephybun
stephybun approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 LGTM 👍

@stephybun stephybun merged commit a98359d into hashicorp:main Dec 2, 2022
@stephybun stephybun added the bug label Dec 2, 2022
@github-actions github-actions bot added this to the v3.35.0 milestone Dec 2, 2022
stephybun added a commit that referenced this pull request Dec 2, 2022
@stephybun
Update for #19516
080e8e7
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
bug service/automation size/XS
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.

azurerm_automation_software_update_configuration needs tag's in Azure Query
2 participants
@wuxu92 @stephybun