-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_spring_cloud_gateway_route_config
- support for the protocol
property
#19382
azurerm_spring_cloud_gateway_route_config
- support for the protocol
property
#19382
Conversation
ms-henglu
commented
Nov 22, 2022
•
edited
Loading
edited
azurerm_spring_cloud_gateway_route_config
- protocol
azurerm_spring_cloud_gateway_route_config
- support for the protocol
property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ms-henglu
Thanks for this PR - I've taken a look through and whilst this PR looks good on the whole I think we need to think about the default value here, using HTTP
as a default rather than HTTPS
(or making this field Required, or not having a default value) is an insecure default -as such we probably need to change this default value.
Thanks!
"protocol": { | ||
Type: pluginsdk.TypeString, | ||
Optional: true, | ||
Default: string(appplatform.GatewayRouteConfigProtocolHTTP), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an insecure default, what's the reasoning for making this HTTP
rather than HTTPS
(or Required?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The server-side's default value is HTTP
, if we make it default to HTTPS
or required field. It will introduce breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this field Required for 4.0 then and also add a note in the docs warning users that this is insecure by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stephybun , I've updated the PR, please take another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ms-henglu LGTM 🎺
This functionality has been released in v3.34.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |