r\application_insights fix workspace_id case that force recreation

[mgattei]

Fix #13348

Please note that this is my first contribution and my go knowledge is really basic.

This should fix the problem that terraform ask for recreation If the resource has a linked workspace.

Things tried before opening the PR:

• Deleting Log Analytics Workspace resource from state
• Deleting Application Insights resource from state
• Reimporting in different order

[tombuildsstuff]

hey @mgattei

Thanks for this PR - I've taken a look through and left some comments inline, but if we can fix those up then this should be good to go. Whilst normally we'd ask for acceptance tests to cover this change, taking a look through it appears that the happy path is covered via the test TestAccApplicationInsights_basicWorkspaceMode, so I think we should be good once this the comments are addressed 👍

Thanks!

[mgattei]

Thanks @tombuildsstuff for the review!

I applied the suggestions and double checked locally, I also tried the test and seems ok.

[tombuildsstuff]

LGTM - thanks for pushing those changes @mgattei

[tombuildsstuff]

Tests pass:

[github-actions]

This functionality has been released in v3.33.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.