Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_[linux|windows]_virtual_machine_scale_set - Allow disabling secure boot when creating a virtual machine scale set with disk encryption type "VMGuestStateOnly" #18749

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Oct 13, 2022

Fixes #18747

@WodansSon WodansSon added bug service/vmss Virtual Machine Scale Sets labels Oct 14, 2022
@WodansSon WodansSon added this to the v3.28.0 milestone Oct 14, 2022
@WodansSon
Copy link
Collaborator

@malt3, thank you for opening this PR, I have given it a look and it LGTM! 🚀

@WodansSon WodansSon changed the title Allow disabling secure boot when creating a virtual machine scale set with disk encryption type "VMGuestStateOnly" azurerm_linux_virtual_machine_scale_set - Allow disabling secure boot when creating a virtual machine scale set with disk encryption type "VMGuestStateOnly" Oct 14, 2022
@malt3 malt3 changed the title azurerm_linux_virtual_machine_scale_set - Allow disabling secure boot when creating a virtual machine scale set with disk encryption type "VMGuestStateOnly" azurerm_[linux|windows]_virtual_machine_scale_set - Allow disabling secure boot when creating a virtual machine scale set with disk encryption type "VMGuestStateOnly" Oct 14, 2022
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malt3 thank you so much for those changes this looks awesome! One last thing can you add a note to each of the affected resources documentation to note the change? If you can do that we should be able to merge this update! Thanks again for pushing those changes! 🚀

…t) with disk encryption type "VMGuestStateOnly"
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malt3, thanks for making those changes, this LGTM now! 🚀

@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon merged commit 1dfe713 into hashicorp:main Oct 18, 2022
WodansSon added a commit that referenced this pull request Oct 18, 2022
@malt3 malt3 deleted the fix/allow-disabling-secure-boot-for-cvm branch October 18, 2022 07:17
@github-actions
Copy link

This functionality has been released in v3.28.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_linux_virtual_machine_scale_set SecurityType ConfidentialVM can only be set with secure boot
2 participants